From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/2] eal: add functions to generate uuid values
Date: Thu, 4 Apr 2024 09:16:08 -0700 [thread overview]
Message-ID: <20240404161608.GB18708@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20240403221319.499014-2-stephen@networkplumber.org>
On Wed, Apr 03, 2024 at 03:11:07PM -0700, Stephen Hemminger wrote:
> Useful to be able to generate uuid values for tests or
> for interaction with other subsystems as magic cookie.
> Naming and overall algorithm come from libuuid which is used
> by permission of original author.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/eal/common/eal_common_uuid.c | 56 ++++++++++++++++++++++++++++++++
> lib/eal/include/rte_uuid.h | 22 ++++++++++++-
> lib/eal/version.map | 2 ++
> 3 files changed, 79 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eal/common/eal_common_uuid.c b/lib/eal/common/eal_common_uuid.c
> index 0a80bfbb38..fc8f58e8a4 100644
> --- a/lib/eal/common/eal_common_uuid.c
> +++ b/lib/eal/common/eal_common_uuid.c
> @@ -7,7 +7,12 @@
> #include <stdint.h>
> #include <stdlib.h>
> #include <ctype.h>
> +#include <time.h>
>
> +#include <rte_atomic.h>
should be rte_stdatomic.h
> +#include <rte_common.h>
> +#include <rte_random.h>
> +#include <rte_time.h>
> #include <rte_uuid.h>
>
> /* UUID packed form */
> @@ -165,3 +170,54 @@ void rte_uuid_unparse(const rte_uuid_t uu, char *out, size_t len)
> uuid.node[0], uuid.node[1], uuid.node[2],
> uuid.node[3], uuid.node[4], uuid.node[5]);
> }
> +
> +void rte_uuid_generate_random(rte_uuid_t out)
> +{
> + union {
> + uint64_t words[2];
> + rte_uuid_t uuid;
> + } buf;
> + struct uuid uu;
> +
> + /* UUID is 128 bit */
> + buf.words[0] = rte_rand();
> + buf.words[1] = rte_rand();
> +
> + /* Mark these random bytes a version 4 random uuid */
> + uuid_unpack(buf.uuid, &uu);
> + uu.clock_seq = (uu.clock_seq & 0x3FFF) | 0x8000;
> + uu.time_hi_and_version = (uu.time_hi_and_version & 0x0FFF) | 0x4000;
> + uuid_pack(&uu, out);
> +}
> +
> +void rte_uuid_generate_time(rte_uuid_t out)
> +{
> + struct uuid uu;
> + struct timespec ts;
> + uint64_t ns, rnd;
> + static uint16_t sequence;
should be ``static RTE_ATOMIC(uint16_t) sequence;``
> +
> + /* The time value for UUID is 100ns since 15 October 1582 */
> + clock_gettime(CLOCK_REALTIME, &ts);
> +
> + ns = ts.tv_nsec / 100;
> + ns += (uint64_t) ts.tv_sec * (NSEC_PER_SEC / 100);
> + ns += (((uint64_t) 0x01B21DD2) << 32) + 0x13814000;
> +
> + uu.time_low = (uint32_t) ns;
> + uu.time_mid = (uint16_t) (ns >> 32);
> + uu.time_hi_and_version = (uint16_t) (ns >> 48);
> + uu.time_hi_and_version = (uu.time_hi_and_version & 0x0FFF) | 0x4000;
> + uu.clock_seq = rte_atomic_fetch_add_explicit(&sequence, 1,
> + rte_memory_order_relaxed);
> +
> + rnd = rte_rand();
> + memcpy(uu.node, &rnd, 6);
> + /*
> + * What libuuid does set multicast bit.
> + * This avoids conflicts with network cards.
> + */
> + uu.node[0] |= 0x1;
> +
> + uuid_pack(&uu, out);
> +}
> diff --git a/lib/eal/include/rte_uuid.h b/lib/eal/include/rte_uuid.h
> index cfefd4308a..052b78a812 100644
> --- a/lib/eal/include/rte_uuid.h
> +++ b/lib/eal/include/rte_uuid.h
> @@ -18,6 +18,8 @@ extern "C" {
> #include <stddef.h>
> #include <string.h>
>
> +#include <rte_compat.h>
> +
> /**
> * Struct describing a Universal Unique Identifier
> */
> @@ -94,12 +96,30 @@ int rte_uuid_parse(const char *in, rte_uuid_t uu);
> * @param uu
> * UUID to format
> * @param out
> - * Resulting string buffer
> + * Resulting string bufferm
intentional change buffer -> bufferm?
> * @param len
> * Sizeof the available string buffer
> */
> void rte_uuid_unparse(const rte_uuid_t uu, char *out, size_t len);
>
> +/**
> + * Generate a random uuid
> + *
> + * @param uu
> + * Resulting UUID
> + */
> +__rte_experimental
> +void rte_uuid_generate_random(rte_uuid_t uu);
> +
> +/**
> + * Generate a uuid based on time stamp.
> + *
> + * @param uu
> + * Resulting UUID
> + */
> +__rte_experimental
> +void rte_uuid_generate_time(rte_uuid_t uu);
> +
> #ifdef __cplusplus
> }
> #endif
> diff --git a/lib/eal/version.map b/lib/eal/version.map
> index 3df50c3fbb..5a8aa67244 100644
> --- a/lib/eal/version.map
> +++ b/lib/eal/version.map
> @@ -396,6 +396,8 @@ EXPERIMENTAL {
>
> # added in 24.03
> rte_vfio_get_device_info; # WINDOWS_NO_EXPORT
# added in 24.07
> + rte_uuid_generate_random;
> + rte_uuid_generate_time;
> };
>
> INTERNAL {
> --
i actually didn't see the RTE_ATOMIC get added in v2 as per cover letter,
so i'm thinking maybe the v1 series was re-submitted as v2?
> 2.43.0
next prev parent reply other threads:[~2024-04-04 16:16 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 16:32 [PATCH 0/2] uuid: enhancements and tests Stephen Hemminger
2024-04-03 16:32 ` [PATCH 1/2] eal: add functions to generate uuid values Stephen Hemminger
2024-04-04 16:11 ` Tyler Retzlaff
2024-04-03 16:32 ` [PATCH 2/2] test: add functional test for uuid Stephen Hemminger
2024-04-03 22:11 ` [PATCH v2 0/2] uuid: add generate functions and tests Stephen Hemminger
2024-04-03 22:11 ` [PATCH v2 1/2] eal: add functions to generate uuid values Stephen Hemminger
2024-04-04 16:16 ` Tyler Retzlaff [this message]
2024-04-03 22:11 ` [PATCH v2 2/2] test: add functional test for uuid Stephen Hemminger
2024-04-04 16:18 ` Tyler Retzlaff
2024-04-04 16:22 ` [PATCH v3 0/2] uuid: add generate functions and tests Stephen Hemminger
2024-04-04 16:22 ` [PATCH v3 1/2] eal: add functions to generate uuid values Stephen Hemminger
2024-04-04 16:22 ` [PATCH v3 2/2] test: add functional test for uuid Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 00/30] replace use of rte_memcpy with fixed sizes Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 01/30] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy Stephen Hemminger
2024-04-06 9:01 ` Morten Brørup
2024-04-05 16:53 ` [PATCH v4 02/30] eal: replace use of " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 03/30] ethdev: replace uses of rte_memcpy Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 04/30] eventdev: replace use of fixed size rte_memcpy Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 05/30] cryptodev: " Stephen Hemminger
2024-04-10 15:40 ` [EXTERNAL] " Akhil Goyal
2024-04-05 16:53 ` [PATCH v4 06/30] ip_frag: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 07/30] net: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 08/30] lpm: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 09/30] node: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 10/30] pdcp: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 11/30] pipeline: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 12/30] rib: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 13/30] security: " Stephen Hemminger
2024-04-10 15:40 ` [EXTERNAL] " Akhil Goyal
2024-04-05 16:53 ` [PATCH v4 14/30] bus: remove unneeded rte_memcpy.h include Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 15/30] net: replace use of fixed size rte_memcpy Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 16/30] raw: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 17/30] baseband: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 18/30] common: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 19/30] crypto: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 20/30] " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 21/30] event: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 22/30] mempool: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 23/30] ml/cnxk: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 24/30] app/test-pmd: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 25/30] app/graph: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 26/30] app/test-eventdev: " Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 27/30] app/test: " Stephen Hemminger
2024-04-10 18:28 ` [EXTERNAL] " Akhil Goyal
2024-04-05 16:53 ` [PATCH v4 28/30] app/test-pipeline: remove unused rte_memcpy.h include Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 29/30] app/test-bbdev: remove unnecessary include of rte_memcpy.h Stephen Hemminger
2024-04-05 16:53 ` [PATCH v4 30/30] examples: replace use of fixed size rte_memcpy Stephen Hemminger
2024-04-09 17:05 ` [PATCH v4 0/2] uuid: generator functions and unit test Stephen Hemminger
2024-04-09 17:05 ` [PATCH v4 1/2] eal: add functions to generate uuid values Stephen Hemminger
2024-04-09 17:05 ` [PATCH v4 2/2] test: add functional test for uuid Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 00/32] replace use of rte_memcpy() with fixed size Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 01/32] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 02/32] eal: replace use of " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 03/32] ethdev: replace uses of rte_memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 04/32] eventdev: replace use of fixed size rte_memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 05/32] cryptodev: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 06/32] ip_frag: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 07/32] net: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 08/32] lpm: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 09/32] node: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 10/32] pdcp: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 11/32] pipeline: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 12/32] rib: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 13/32] security: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 14/32] bus: remove unneeded rte_memcpy.h include Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 15/32] raw: replace use of fixed size rte_memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 16/32] baseband: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 17/32] common: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 18/32] crypto: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 19/32] event: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 20/32] mempool: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 21/32] ml/cnxk: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 22/32] app/test-pmd: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 23/32] app/graph: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 24/32] app/test-eventdev: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 25/32] app/test: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 26/32] app/test-pipeline: remove unused rte_memcpy.h include Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 27/32] app/test-bbdev: remove unnecessary include of rte_memcpy.h Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 28/32] examples: replace use of fixed size rte_memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 29/32] net/null: replace use of fixed size memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 30/32] net/tap: replace use of fixed size rte_memcpy Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 31/32] net/pcap: " Stephen Hemminger
2024-05-22 3:27 ` [PATCH v5 32/32] net/af_xdp:: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240404161608.GB18708@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).