From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>
Subject: Re: [PATCH v3 4/5] latencystats: fix log messages
Date: Wed, 17 Apr 2024 17:13:22 -0700 [thread overview]
Message-ID: <20240418001322.GD26881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20240417170908.76701-5-stephen@networkplumber.org>
On Wed, Apr 17, 2024 at 10:07:26AM -0700, Stephen Hemminger wrote:
> All messages that because of an error should be at log level
> NOTICE or above. Do not break log messages across lines.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/latencystats/rte_latencystats.c | 30 ++++++++++++++---------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c
> index 11bd0ea4ae..62038a9f5d 100644
> --- a/lib/latencystats/rte_latencystats.c
> +++ b/lib/latencystats/rte_latencystats.c
> @@ -235,7 +235,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
> latency_stats_index = rte_metrics_reg_names(ptr_strings,
> NUM_LATENCY_STATS);
> if (latency_stats_index < 0) {
> - LATENCY_STATS_LOG(DEBUG,
> + LATENCY_STATS_LOG(ERR,
> "Failed to register latency stats names");
> return -1;
> }
> @@ -255,7 +255,7 @@ rte_latencystats_init(uint64_t app_samp_intvl,
>
> ret = rte_eth_dev_info_get(pid, &dev_info);
> if (ret != 0) {
> - LATENCY_STATS_LOG(INFO,
> + LATENCY_STATS_LOG(NOTICE,
> "Error during getting device (port %u) info: %s",
nit: the level is notice, but the message says 'Error' same in a couple
of other instances below. arguably fine so you can ignore me.
> pid, strerror(-ret));
>
> @@ -267,18 +267,18 @@ rte_latencystats_init(uint64_t app_samp_intvl,
> cbs->cb = rte_eth_add_first_rx_callback(pid, qid,
> add_time_stamps, user_cb);
> if (!cbs->cb)
> - LATENCY_STATS_LOG(INFO, "Failed to "
> - "register Rx callback for pid=%d, "
> - "qid=%d", pid, qid);
> + LATENCY_STATS_LOG(NOTICE,
> + "Failed to register Rx callback for pid=%u, qid=%u",
> + pid, qid);
> }
> for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
> cbs = &tx_cbs[pid][qid];
> cbs->cb = rte_eth_add_tx_callback(pid, qid,
> calc_latency, user_cb);
> if (!cbs->cb)
> - LATENCY_STATS_LOG(INFO, "Failed to "
> - "register Tx callback for pid=%d, "
> - "qid=%d", pid, qid);
> + LATENCY_STATS_LOG(NOTICE,
> + "Failed to register Tx callback for pid=%u, qid=%u",
> + pid, qid);
> }
> }
> return 0;
> @@ -299,7 +299,7 @@ rte_latencystats_uninit(void)
>
> ret = rte_eth_dev_info_get(pid, &dev_info);
> if (ret != 0) {
> - LATENCY_STATS_LOG(INFO,
> + LATENCY_STATS_LOG(NOTICE,
> "Error during getting device (port %u) info: %s",
> pid, strerror(-ret));
>
> @@ -310,17 +310,17 @@ rte_latencystats_uninit(void)
> cbs = &rx_cbs[pid][qid];
> ret = rte_eth_remove_rx_callback(pid, qid, cbs->cb);
> if (ret)
> - LATENCY_STATS_LOG(INFO, "failed to "
> - "remove Rx callback for pid=%d, "
> - "qid=%d", pid, qid);
> + LATENCY_STATS_LOG(NOTICE,
> + "Failed to remove Rx callback for pid=%u, qid=%u",
> + pid, qid);
> }
> for (qid = 0; qid < dev_info.nb_tx_queues; qid++) {
> cbs = &tx_cbs[pid][qid];
> ret = rte_eth_remove_tx_callback(pid, qid, cbs->cb);
> if (ret)
> - LATENCY_STATS_LOG(INFO, "failed to "
> - "remove Tx callback for pid=%d, "
> - "qid=%d", pid, qid);
> + LATENCY_STATS_LOG(NOTICE,
> + "Failed to remove Tx callback for pid=%u, qid=%u",
> + pid, qid);
> }
> }
>
> --
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
next prev parent reply other threads:[~2024-04-18 0:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0240408195036.182545-1-stephen@networkplumber.org>
2024-04-17 17:07 ` [PATCH v3 0/5] latencystats: cleanups Stephen Hemminger
2024-04-17 17:07 ` [PATCH v3 1/5] latencystats: replace use of VLA Stephen Hemminger
2024-04-17 18:03 ` Morten Brørup
2024-04-17 18:13 ` Stephen Hemminger
2024-04-18 0:00 ` Tyler Retzlaff
2024-04-17 17:07 ` [PATCH v3 2/5] latencystats: handle fractional cycles per ns Stephen Hemminger
2024-04-18 0:03 ` Tyler Retzlaff
2024-04-17 17:07 ` [PATCH v3 3/5] latencystats: do not use floating point Stephen Hemminger
2024-04-18 0:10 ` Tyler Retzlaff
2024-04-17 17:07 ` [PATCH v3 4/5] latencystats: fix log messages Stephen Hemminger
2024-04-18 0:13 ` Tyler Retzlaff [this message]
2024-04-17 17:07 ` [PATCH v3 5/5] latencystats: include file cleanup Stephen Hemminger
2024-04-17 17:30 ` Bruce Richardson
2024-04-17 18:13 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418001322.GD26881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).