From: Stephen Hemminger <stephen@networkplumber.org>
To: 吴剑跃 <wujianyue000@163.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] eal/linux: enhanced error handling for affinity
Date: Thu, 25 Apr 2024 08:04:46 -0700 [thread overview]
Message-ID: <20240425080446.4443fe24@hermes.local> (raw)
In-Reply-To: <5def5f15.73a1.18f13c4e490.Coremail.wujianyue000@163.com>
On Thu, 25 Apr 2024 13:40:21 +0800 (CST)
吴剑跃 <wujianyue000@163.com> wrote:
> After reviewing the code, I believe that the combination of the __linux__ and _GNU_SOURCE macros effectively confirms whether the pthread_getname_np() API can be utilized. I will proceed with adding them. Thank you~
> #if defined(__linux__) && defined(_GNU_SOURCE)
>
>
> 在 2024-04-25 09:08:59，"吴剑跃" <wujianyue000@163.com> 写道：
>
> Hello, Stephen,
>
>
>
> Good day
> The issue is not caused by DPDK itself, but arises when the DPDK worker process attempts to set affinity to a cpuset that exceeds the limits set by the cgroup cpuset settings.
> Original error prints are:
> PANIC in rte_eal_init():
> Cannot set affinity
> # Callstacks.
>
>
> Finding the detailed reason for the failure was challenging, so I added extra print statements to help diagnose the issue.
> I understand your concern about maintaining OS independence with the rte_thread functions. This change aims to provide more context when errors occur, facilitating quicker troubleshooting. I agree that this introduces more code and could be seen as platform-specific. Perhaps we could implement this conditionally, only for platforms where such detailed logging is supported and useful.
>
My point is that just giving the kernel error should be sufficient, rather than having
to reformat the incoming arguments. The arguments are coming from the command line, and what I
would do is look at the error and the command line arguments to the application, as well as
any kernel logs.
next prev parent reply other threads:[~2024-04-25 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 3:02 Jianyue Wu
2024-04-24 15:50 ` Stephen Hemminger
2024-04-25 1:08 ` 吴剑跃
2024-04-25 5:40 ` 吴剑跃
2024-04-25 15:04 ` Stephen Hemminger [this message]
2024-04-26 3:14 ` Jianyue Wu
-- strict thread matches above, loose matches on Subject: below --
2021-06-09 11:25 [dpdk-dev] Does memif support primary<->secondary process communication? Wu, Jianyue (NSB - CN/Hangzhou)
2021-06-09 12:07 ` Wu, Jianyue (NSB - CN/Hangzhou)
2024-04-22 13:23 ` [PATCH] eal/linux: enhanced error handling for affinity Jianyue Wu (NSB)
2024-04-22 13:49 ` Ferruh Yigit
2024-04-26 21:31 ` Patrick Robb
2024-04-22 13:50 ` Ferruh Yigit
2024-04-22 15:26 ` Stephen Hemminger
2024-04-22 15:27 ` Stephen Hemminger
2024-04-22 15:30 ` Stephen Hemminger
2024-04-23 3:01 ` Jianyue Wu (NSB)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240425080446.4443fe24@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=wujianyue000@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).