From: Daniel Gregory <daniel.gregory@bytedance.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>,
dev@dpdk.org, Punit Agrawal <punit.agrawal@bytedance.com>,
Liang Ma <liangma@bytedance.com>
Subject: Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant
Date: Fri, 3 May 2024 15:21:18 +0100 [thread overview]
Message-ID: <20240503142118.GC3883350@ste-uk-lab-gw> (raw)
In-Reply-To: <CAJFAV8x=vHEn2ezKBSTrKJGxYwDe_DKv7s26_4FVBHxiqQmcvg@mail.gmail.com>
On Fri, May 03, 2024 at 03:32:20PM +0200, David Marchand wrote:
> - RTE_BUILD_BUG_ON() should not be used indeed.
> IIRC, this issue was introduced with 875f350924b8 ("eal: add a new
> helper for wait until scheme").
> Please add a corresponding Fixes: tag in next revision.
Will do. Should I CC stable@dpdk.org too?
> - This ARM specific implementation should take a rte_memory_order type
> instead of a int type for the memorder input variable.
> This was missed in 1ec6a845b5cb ("eal: use stdatomic API in public headers").
>
> Could you send a fix for this small issue too?
Yes, sure thing.
Thanks, Daniel
next prev parent reply other threads:[~2024-05-03 14:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 14:21 Daniel Gregory
2024-05-02 16:20 ` Stephen Hemminger
2024-05-02 17:44 ` Daniel Gregory
2024-05-02 18:27 ` Stephen Hemminger
2024-05-02 21:48 ` Stephen Hemminger
2024-05-03 9:46 ` Daniel Gregory
2024-05-04 0:56 ` Stephen Hemminger
2024-05-09 11:02 ` Daniel Gregory
2024-05-03 13:32 ` David Marchand
2024-05-03 14:21 ` Daniel Gregory [this message]
2024-05-03 18:27 ` [PATCH v2] " Daniel Gregory
2024-05-03 18:30 ` Daniel Gregory
2024-05-04 0:59 ` Stephen Hemminger
2024-05-06 9:30 ` Ruifeng Wang
2024-05-11 17:00 ` Wathsala Wathawana Vithanage
2024-05-04 1:02 ` [PATCH] " Stephen Hemminger
2024-05-09 11:11 ` Daniel Gregory
2024-05-09 16:47 ` Tyler Retzlaff
2024-05-11 16:48 ` Wathsala Wathawana Vithanage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240503142118.GC3883350@ste-uk-lab-gw \
--to=daniel.gregory@bytedance.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=liangma@bytedance.com \
--cc=punit.agrawal@bytedance.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).