From: Thomas Monjalon <thomas@monjalon.net>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: dev@dpdk.org, "Hunt, David" <david.hunt@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Parthasarathy, JananeeX M" <jananeex.m.parthasarathy@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests
Date: Wed, 25 Apr 2018 00:34:11 +0200 [thread overview]
Message-ID: <2027071.Zq3VvV6ELG@xps> (raw)
In-Reply-To: <3AEA2BF9852C6F48A459DA490692831F2A2C9138@irsmsx110.ger.corp.intel.com>
24/04/2018 14:51, Pattan, Reshma:
> From: Hunt, David
> > On 24/4/2018 12:23 PM, Pattan, Reshma wrote:
> > > From: Richardson, Bruce
> > >> On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote:
> > >>> 11/04/2018 16:14, Reshma Pattan:
> > >>>> Unit Testcases are added for power_acpi_cpu_freq,
> > power_kvm_vm_test
> > >>>> to improve coverage
> > >>>>
> > >>>> Signed-off-by: Jananee Parthasarathy
> > >>>> <jananeex.m.parthasarathy@intel.com>
> > >>>> Acked-by: David Hunt <david.hunt@intel.com>
> > >>> Applied, thanks
> > >>>
> > >> Sadly, this patch seems to break shared library builds. If you try
> > >> doing "make test-build" with shared libraries on it will fail, or if
> > >> you do a meson build using shared libraries you will get the same result.
> > >>
> > >> The root cause is that the function guest_channel_host_connect() is a
> > >> private function and so is not listed in the shared library map file,
> > >> preventing the test app from linking.
> > >>
> > > Any action from my side required? Let me know.
> >
> > Reshma,
> > Looking at this, I think this particular unit test needs to be removed. The
> > way it is at the moment, it's "faking" the connect, then any commands that
> > are sent to the dummy host are only really to test to see if the API breaks,
> > which is going to be captured by compilation tests anyway. I don't see the
> > value of this unit test unless you have the full host setup underneath is, in
> > which case it's no longer a unit test.
> > Also, we don't want to make these functions public, as they are only of use to
> > the library internally, and there is no use for them publicly (unless a guest
> > wants to fake a connection to a non-existent host).
> >
> > What do you think?
>
> Fine, we are reverting the changes and will send the patch soon.
Where is the patch?
I will revert it myself.
next prev parent reply other threads:[~2018-04-24 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 13:51 [dpdk-dev] [PATCH] " Reshma Pattan
2018-04-10 14:19 ` Hunt, David
2018-04-11 14:14 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2018-04-23 21:04 ` Thomas Monjalon
2018-04-24 10:58 ` Bruce Richardson
2018-04-24 11:23 ` Pattan, Reshma
2018-04-24 12:09 ` Hunt, David
2018-04-24 12:51 ` Pattan, Reshma
2018-04-24 22:34 ` Thomas Monjalon [this message]
2018-04-24 22:35 ` Pattan, Reshma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2027071.Zq3VvV6ELG@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).