From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header
Date: Tue, 01 May 2018 20:56:28 +0200 [thread overview]
Message-ID: <2051771.Q7AAqi1qgL@xps> (raw)
In-Reply-To: <20180501172815.214973-1-ferruh.yigit@intel.com>
01/05/2018 19:28, Ferruh Yigit:
> --- a/lib/librte_ethdev/rte_ethdev.c
> +++ b/lib/librte_ethdev/rte_ethdev.c
> -static int ethdev_logtype;
> -
> -#define ethdev_log(level, fmt, ...) \
> - rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ## __VA_ARGS__)
> +int ethdev_logtype;
>
[...]
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> +extern int ethdev_logtype;
> +
> +#define RTE_ETHDEV_LOG(level, fmt, ...) \
> + rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ## __VA_ARGS__)
Why moving this macro in the header file? For using it in inline functions?
Probably worth an explanation in the commit message.
next prev parent reply other threads:[~2018-05-01 18:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 17:28 Ferruh Yigit
2018-05-01 17:28 ` [dpdk-dev] [PATCH 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-05-01 18:56 ` Thomas Monjalon [this message]
2018-05-02 9:40 ` [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header Ferruh Yigit
2018-05-02 14:45 ` Stephen Hemminger
2018-05-09 14:24 ` [dpdk-dev] [PATCH v2 " Ferruh Yigit
2018-05-09 14:24 ` [dpdk-dev] [PATCH v2 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-05-14 15:56 ` [dpdk-dev] [PATCH v3 1/2] ethdev: move log macro to header Ferruh Yigit
2018-05-14 15:56 ` [dpdk-dev] [PATCH v3 2/2] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-06-19 1:04 ` [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header Ferruh Yigit
2018-06-19 1:04 ` [dpdk-dev] [PATCH v4 2/3] ethdev: convert static logtype usage to dynamic Ferruh Yigit
2018-06-19 13:11 ` Andrew Rybchenko
2018-06-19 1:04 ` [dpdk-dev] [PATCH v4 3/3] eal: don't enable static log macro for ethdev Ferruh Yigit
2018-06-19 13:02 ` [dpdk-dev] [PATCH v4 1/3] ethdev: move log macro to header Andrew Rybchenko
2018-06-26 11:41 ` Shahaf Shuler
2018-06-26 12:25 ` Thomas Monjalon
2018-06-26 15:52 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2051771.Q7AAqi1qgL@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).