patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Neil Horman <nhorman@tuxdriver.com>,
	David Marchand <david.marchand@redhat.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] compat: merge compat library into EAL
Date: Mon, 25 Feb 2019 15:59:57 +0100	[thread overview]
Message-ID: <2063813.xZsQsPevWC@xps> (raw)
In-Reply-To: <20190206110130.55135-1-bruce.richardson@intel.com>

06/02/2019 12:01, Bruce Richardson:
> Since compat library is only a single header, we can easily move it into
> the EAL common headers instead of tracking it separately. The downside of
> this is that it becomes a little more difficult to have any libs that are
> built before EAL depend on it. Thankfully, this is not a major problem as
> the only library which uses rte_compat.h and is built before EAL (kvargs)
> already has the path to the compat.h header file explicitly called out as
> an include path.
> 
> However, to ensure that we don't hit problems later with this, we can add
> EAL common headers folder to the global include list in the meson build
> which means that all common headers can be safely used by all libraries, no
> matter what their build order.
> 
> As a side-effect, this patch also fixes an issue with building on BSD using
> meson, due to compat lib no longer needing to be listed as a dependency.
> 
> Fixes: a8499f65a1d1 ("log: add missing experimental tag")
> 
> CC: stable@dpdk.org
> CC: Neil Horman <nhorman@tuxdriver.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> Tested-by: David Marchand <david.marchand@redhat.com>
> Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks

      parent reply	other threads:[~2019-02-25 15:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190110111104.56464-1-bruce.richardson@intel.com>
     [not found] ` <20190110134732.57052-1-bruce.richardson@intel.com>
2019-01-10 13:57   ` [dpdk-stable] [PATCH v2] " David Marchand
2019-01-10 14:01     ` Bruce Richardson
2019-02-06 11:01 ` [dpdk-stable] [PATCH v3] " Bruce Richardson
2019-02-06 12:22   ` Neil Horman
2019-02-06 14:17     ` Bruce Richardson
2019-02-07 14:34       ` Neil Horman
2019-02-07 15:03         ` Bruce Richardson
2019-02-08 15:37           ` Neil Horman
2019-02-08 16:18             ` Bruce Richardson
2019-02-08 16:55               ` Neil Horman
2019-02-08 17:13                 ` Bruce Richardson
2019-02-25 14:25                   ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-02-25 14:59   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2063813.xZsQsPevWC@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).