From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] scripts: add git hook scripts for checkpatch and auto doc generation
Date: Tue, 24 Nov 2015 18:44:36 +0100 [thread overview]
Message-ID: <2076055.LzC464LxxN@xps13> (raw)
In-Reply-To: <1446817732-17873-2-git-send-email-ferruh.yigit@intel.com>
Thanks for the idea
2015-11-06 13:48, Ferruh Yigit:
> post-merge: Same script as "post-commit", but triggered after git pull
A symbolic link would be sufficient.
As it must be installed in the git hooks (probably making a symbolic link),
duplicating the file is not needed at all.
> pre-commit: Does a checkpatch check before commit started. If script
> finds any error it will print warnings and fails. If checkpatch
> fails commit also fails. This guaranties every commit pass checkpatch.
> Default script is <dpdk>/scripts/checkpatch.pl but this can be
> changed by RTE_CHECKPATCH environment variable. Also a default list
> of checkpatch ignore items defined, new ones can be added by IGNORE
> environment variable.
Please use the new scripts/checkpatches.sh:
http://dpdk.org/dev/patchwork/patch/9036/
> This script can bypassed by commit "--no-verify" argument.
Could you document the --no-verify option in the script?
> Deployment:
> To make scripts active they need to be in <dpdk>/.git/hooks folder.
> Alternatively "deploy.sh" script can be used, it simply copies all
> scripts into proper folder. Script names are significant and
> shouldn't changed.
Why not using symbolic links?
next prev parent reply other threads:[~2015-11-24 17:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 23:22 Ferruh Yigit
2015-11-06 13:48 ` Ferruh Yigit
2015-11-06 13:48 ` Ferruh Yigit
2015-11-24 17:44 ` Thomas Monjalon [this message]
2015-11-24 18:04 ` Ferruh Yigit
2015-11-06 14:03 ` Ferruh Yigit
2015-11-27 14:34 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2015-12-03 19:09 ` Thomas Monjalon
2015-12-07 13:32 ` Ferruh Yigit
2015-12-07 15:06 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2076055.LzC464LxxN@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).