From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address filtering
Date: Wed, 28 Mar 2018 14:52:57 +0100 [thread overview]
Message-ID: <207d4b8b-ba73-4e27-9057-f51a8c6212db@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061153175795@SHSMSX103.ccr.corp.intel.com>
On 3/28/2018 11:15 AM, Zhang, Qi Z wrote:
> Hi Ferruh:
>
>> -----Original Message-----
>> From: Yigit, Ferruh
>> Sent: Wednesday, March 28, 2018 6:01 PM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Olivier Matz
>> <olivier.matz@6wind.com>; dev@dpdk.org; Xing, Beilei
>> <beilei.xing@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address
>> filtering
>>
>> On 3/27/2018 2:51 PM, Zhang, Qi Z wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier Matz
>>>> Sent: Thursday, January 25, 2018 10:36 PM
>>>> To: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
>>>> <qi.z.zhang@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>
>>>> Subject: [dpdk-dev] [PATCH] net/i40evf: add multicast MAC address
>>>> filtering
>>>>
>>>> Add support the set_mc_addr_list device operation in the i40evf PMD.
>>>>
>>>> The configured addresses are stored in the device private area, so
>>>> they can be flushed before adding new ones.
>>>>
>>>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>>>
>>> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>>>
>>> Thanks for enable this!
>>
>> Hi Qi,
>>
>> This feature was already documented as supported in i40e_vf.ini which
>> seems wrong but now it is supported.
>>
>> i40e also documents this feature as supported, can you please check if the
>> feature is supported there and update i40e.ini if required?
>
> Do you mean
>
> " Multicast MAC filter = Y" ?
>
> My understanding is, though i40e PF/VF doesn't support set_mc_addr_list, but we still can use mac_addr_add to add a multi cast address, so we still have that flag on in i40e.ini.
Right, current "mac_addr_add" dev_ops lets setting multicast addresses. In this
logic if HW supports setting multicast address PMD may claim this support.
Or this may explicitly mean implementing set_mc_addr_list dev_ops in driver.
These feature list is to help user / application developer about what to expect
and what to not from drivers.
A user may expect set_mc_addr_list dev_ops is implemented when this feature
documented and it may be confusing when it fails.
Overall which information, hw supports setting mc mad address or
set_mc_addr_list implemented, adds more value from user point of view? What do
you think?
>
> Regards
> Qi
>
>>
>> Thanks,
>> ferruh
next prev parent reply other threads:[~2018-03-28 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 14:36 Olivier Matz
2018-03-27 13:51 ` Zhang, Qi Z
2018-03-27 13:54 ` Zhang, Helin
2018-03-28 10:00 ` Ferruh Yigit
2018-03-28 10:15 ` Zhang, Qi Z
2018-03-28 13:52 ` Ferruh Yigit [this message]
2018-03-28 14:23 ` Zhang, Qi Z
2018-03-28 14:31 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=207d4b8b-ba73-4e27-9057-f51a8c6212db@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=qi.z.zhang@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).