From: fengchengwen <fengchengwen@huawei.com>
To: Huisong Li <lihuisong@huawei.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<aman.deep.singh@intel.com>, <yuying.zhang@intel.com>,
<zhichaox.zeng@intel.com>
Subject: Re: [PATCH v2] app/testpmd: fix UDP cksum error for UFO enable
Date: Fri, 27 Oct 2023 14:15:40 +0800 [thread overview]
Message-ID: <20989101-d626-d3f3-933c-f67b5ac1bcde@huawei.com> (raw)
In-Reply-To: <20230802025520.8000-1-lihuisong@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2023/8/2 10:55, Huisong Li wrote:
> The command "tso set <tso_segsz> <port_id>" is used to enable UFO, please
> see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine")
>
> The above patch configures the RTE_MBUF_F_TX_UDP_SEG to enable UFO only if
> tso_segsz is set. Then tx_prepare() may call rte_net_intel_cksum_prepare()
> to compute pseudo header checksum (because some PMDs may supports TSO).
> As a result, if the peer sends UDP packets, all packets with UDP checksum
> error are received for the PMDs only supported TSO.
>
> So enabling UFO also depends on if driver has RTE_ETH_TX_OFFLOAD_UDP_TSO
> capability. Similarly, TSO also need to do like this.
>
> In addition, this patch also fixes cmd_tso_set_parsed() for UFO to make
> it better to support TSO and UFO.
>
> Fixes: ce8e6e742807 ("app/testpmd: support UFO in checksum engine")
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
...
next prev parent reply other threads:[~2023-10-27 6:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 2:13 [PATCH] " Huisong Li
2023-08-02 2:55 ` [PATCH v2] " Huisong Li
2023-10-20 3:38 ` lihuisong (C)
2023-10-27 6:15 ` fengchengwen [this message]
2023-11-03 1:31 ` Ferruh Yigit
2023-11-03 9:09 ` lihuisong (C)
2023-11-03 10:42 ` Ferruh Yigit
2023-11-06 4:13 ` lihuisong (C)
2023-11-06 10:09 ` Ferruh Yigit
2023-11-06 12:29 ` lihuisong (C)
2023-11-07 4:11 ` [PATCH v3 0/2] " Huisong Li
2023-11-07 4:11 ` [PATCH v3 1/2] app/testpmd: remove useless code for TSO setting command Huisong Li
2023-11-07 4:11 ` [PATCH v3 2/2] app/testpmd: fix UDP cksum error for UFO enable Huisong Li
2023-11-07 9:54 ` [PATCH v3 0/2] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20989101-d626-d3f3-933c-f67b5ac1bcde@huawei.com \
--to=fengchengwen@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).