From: Thomas Monjalon <thomas@monjalon.net>
To: Dan Gora <dg@adax.com>
Cc: dev@dpdk.org, Remy Horton <remy.horton@intel.com>,
Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ipsec-secgw: use rte fcn to access private area
Date: Fri, 13 Jul 2018 23:10:06 +0200 [thread overview]
Message-ID: <2130840.OQuRDGvn39@xps> (raw)
In-Reply-To: <20180618233618.21729-1-dg@adax.com>
19/06/2018 01:36, Dan Gora:
> Update get_priv() to use rte_mbuf_to_priv() to access the private
> area in the mbuf.
>
> Signed-off-by: Dan Gora <dg@adax.com>
> ---
> - return RTE_PTR_ADD(m, sizeof(struct rte_mbuf));
> + return (ipsec_mbuf_metadata *)rte_mbuf_to_priv(m);
The cast is wrong (struct is missing) and useless.
I will remove it on apply.
prev parent reply other threads:[~2018-07-13 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 23:36 Dan Gora
2018-07-13 21:10 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2130840.OQuRDGvn39@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dg@adax.com \
--cc=orika@mellanox.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=radu.nicolau@intel.com \
--cc=remy.horton@intel.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).