From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Frederico Cadete <frederico@cadete.eu>,
"Frederico.Cadete-ext@oneaccess-net.com"
<Frederico.Cadete-ext@oneaccess-net.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] testpmd: fix fdir command on MAC and tunnel modes
Date: Tue, 25 Oct 2016 23:14:14 +0200 [thread overview]
Message-ID: <2131812.eDc2xJHoTn@xps13> (raw)
In-Reply-To: <CAL5ScNVyW=UU9A_X6BJ+BA53bkae=4W-OLqO31FHQgEynNHmsw@mail.gmail.com>
2016-09-27 11:01, Frederico Cadete:
> On Tue, Sep 27, 2016 at 4:42 AM, Wu, Jingjing <jingjing.wu@intel.com> wrote:
> > From: Frederico.Cadete-
> >> The flow_director_filter commands has a pf|vf option for most modes
> >> except for MAC-VLAN and tunnel. On Intel NIC's these modes are not
> >> supported under virtualized environments.
> >> But the application was checking that this field was parsed for these cases,
> >> even though this token is not registered with the cmdline parser.
> >>
> >> This patch skips checking of this field for the commands that don't accept it.
> >>
> >> Signed-off-by: Frederico Cadete <Frederico.Cadete-ext@oneaccess-net.com>
[...]
> >
> > Thanks for the patch.
>
> And thanks a lot for the review.
>
> > But with this change the field of pf_vf cannot omit either.
> > I think it still looks confused because it will allow any meaningless string.
>
> Sorry, I am not aware that it can be omitted.
> For MAC/VLAN and tunnel mode it does not and will not allow any
> meaningless string.
> At least that was my intention :)
>
> The cmdline parser expects "... flexbytes (flexbytes_value) (drop|fwd)
> queue ..." .
> This is what is documented [1] and the command's cmdline_parse_inst_t
> [2] matches this.
> If you put something in-between "(drop|fwd)" and "queue" it is
> rejected by the parser
> in librte_cmdline.
>
> > In MAC_VLAN or TUNNEL mode, why not just use pf.
>
> With the current code, because if you write that in the command, it is
> rejected by the parser :)
>
> Do you mean it would be preferable to make these commands always take
> such an argument,
> and only at the NIC driver check that it must equal PF for MAC_VLAN or
> TUNNEL mode?
> The command becomes a bit more complicated for the current intel
> NIC's, but as I understand
> it currently does not work anyway. Unless I'm missing something else.
>
> >
> > Maybe an optional field supporting on DPDK cmdline library is exactly what we
> > Are waiting for :)
>
> Laudable goal! My excuses but it's beyond my current skills and bandwith :/
Thanks Frederico.
Your approach has been re-submitted and fixed by Wenzhuo:
http://dpdk.org/patch/16679
prev parent reply other threads:[~2016-10-25 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 9:10 Frederico.Cadete-ext
2016-09-23 18:37 ` Thomas Monjalon
2016-09-27 2:42 ` Wu, Jingjing
2016-09-27 9:01 ` Frederico Cadete
2016-10-25 21:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2131812.eDc2xJHoTn@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=Frederico.Cadete-ext@oneaccess-net.com \
--cc=dev@dpdk.org \
--cc=frederico@cadete.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).