From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] vhost: avoid memory barriers when no descriptors dequeued
Date: Mon, 22 Oct 2018 10:31:44 +0200 [thread overview]
Message-ID: <2132245c-4a16-b858-ab7f-fd2e7f94134b@redhat.com> (raw)
In-Reply-To: <20181022071510.GA30145@debian>
On 10/22/2018 09:15 AM, Tiwei Bie wrote:
> On Fri, Oct 19, 2018 at 04:00:58PM +0200, Maxime Coquelin wrote:
>> In both split and packed dequeue paths, flush_shadow_used_ring
>> and vhost_ring_call variants gets called even if not packets
>> have been dequeued, and so no descriptors updates happened.
>>
>> It has an impact on CPU pipeline, as memory barriers are used
>> in these functions.
>>
>> This patch don't call these functions if no descriptors have
>> been dequeued. The performance gain with split ring when
>> dequeue zero-copy is disabled should be null, but should be
>> noticeable with packed ring or dequeue zero-copy enabled.
>>
>> Fixes: ae999ce49dcb ("vhost: add Tx support for packed ring")
>> Fixes: 915cf9404225 ("vhost: use shadow used ring in dequeue path")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/librte_vhost/virtio_net.c | 16 ++++++++++------
>> 1 file changed, 10 insertions(+), 6 deletions(-)
> [...]
>>
>> - if (likely(dev->dequeue_zero_copy == 0)) {
>> + if (likely(dev->dequeue_zero_copy == 0 && i != 0)) {
>> do_data_copy_dequeue(vq);
>> if (unlikely(i < count))
>> vq->shadow_used_idx = i;
>
> When i is 0, we may need to update vq->shadow_used_idx to 0,
> e.g. when error happens after update_shadow_used_ring_split()
> in the first iteration of the loop.
I totally agree, it is broken when error happens.
I will fix that in next revision.
Thanks,
Maxime
>
>> @@ -1475,8 +1477,10 @@ virtio_dev_tx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq,
>> }
>> }
>>
>> - flush_shadow_used_ring_packed(dev, vq);
>> - vhost_vring_call_packed(dev, vq);
>> + if (likely(vq->shadow_used_idx)) {
>> + flush_shadow_used_ring_packed(dev, vq);
>> + vhost_vring_call_packed(dev, vq);
>> + }
>> }
>>
>> VHOST_LOG_DEBUG(VHOST_DATA, "(%d) %s\n", dev->vid, __func__);
>> @@ -1550,7 +1554,7 @@ virtio_dev_tx_packed(struct virtio_net *dev, struct vhost_virtqueue *vq,
>> }
>> }
>>
>> - if (likely(dev->dequeue_zero_copy == 0)) {
>> + if (likely(dev->dequeue_zero_copy == 0 && i != 0)) {
>
> Ditto
>
>> do_data_copy_dequeue(vq);
>> if (unlikely(i < count))
>> vq->shadow_used_idx = i;
>> --
>> 2.17.1
>>
prev parent reply other threads:[~2018-10-22 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 14:00 Maxime Coquelin
2018-10-22 7:15 ` Tiwei Bie
2018-10-22 8:31 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2132245c-4a16-b858-ab7f-fd2e7f94134b@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).