From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Billy McFall <bmcfall@redhat.com>
Cc: wenzhuo.lu@intel.com, olivier.matz@6wind.com, dev@dpdk.org,
adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: new API to free consumed buffers in Tx ring
Date: Thu, 09 Mar 2017 18:11:25 +0100 [thread overview]
Message-ID: <2146383.vtkpvASGrJ@xps13> (raw)
In-Reply-To: <CAKLkqD6y243LN7CTjeq6b3DWTUKjwUzad+2jv-iuO5Rzo6G5Lw@mail.gmail.com>
2017-03-09 10:49, Billy McFall:
> On Tue, Mar 7, 2017 at 11:03 AM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > 2017-03-07 09:29, Billy McFall:
> > > On Mon, Feb 27, 2017 at 8:48 AM, Thomas Monjalon <
> > thomas.monjalon@6wind.com>
> > > wrote:
> > > > I think you could use rte_errno (while keeping negative return codes).
> > > >
> > >
> > > I can do that if you want, but if I understand your comment, it will make
> > > the implementation of the function not as clean. I cannot use the
> > existing
> > > RTE_ETH_VALID_PORTID_OR_ERR_RET(..) and RTE_FUNC_PTR_OR_ERR_RET(..)
> > MACROs
> > > because they are handling the return on error. Or am I missing something?
> >
> > Yes. Maybe we need new macros for basic error management with rte_errno.
> >
> > Looking at the code. Do you think we need new MACROs or just set rte_errno
> in the existing? What would be the down side to setting rte_errno for all
> the existing calls?
>
> Looks like RTE_ETH_VALID_PORTID_OR_ERR_RET(..) is being called ~135 times.
> Most calls are with retval set to either -ENODEV or -EINVAL. A few
> instances of 0 and -1, but not many.
>
> Looks like RTE_FUNC_PTR_OR_ERR_RET(..) is being called ~100 times. Most
> calls are with retval set to -ENOTSUP. A few instances of 0, but not many.
>
> I was thinking:
> /* Macros to check for valid port */
> #define RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, retval) do { \
> if (!rte_eth_dev_is_valid_port(port_id)) { \
> RTE_PMD_DEBUG_TRACE("Invalid port_id=%d\n", port_id); \
> + if (retval < 0) \
> + rte_errno = -retval; \
> return retval; \
> } \
> } while (0)
Yes it seems acceptable.
This rework may be done separately.
next prev parent reply other threads:[~2017-03-09 17:11 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 16:01 [dpdk-dev] [PATCH v3 0/3] " Billy McFall
2017-01-20 16:01 ` [dpdk-dev] [PATCH v3 1/3] ethdev: " Billy McFall
2017-01-20 16:01 ` [dpdk-dev] [PATCH v3 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-01-22 3:47 ` Lu, Wenzhuo
2017-01-23 13:49 ` Billy McFall
2017-01-24 0:42 ` Lu, Wenzhuo
2017-01-20 16:01 ` [dpdk-dev] [PATCH v3 3/3] net/vhost: vHost " Billy McFall
2017-01-23 15:25 ` [dpdk-dev] [PATCH v3 0/3] new API to free consumed buffers in Tx ring Thomas Monjalon
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 " Billy McFall
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 1/3] ethdev: " Billy McFall
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-01-23 21:13 ` [dpdk-dev] [PATCH v4 3/3] net/vhost: vHost " Billy McFall
2017-01-27 18:37 ` [dpdk-dev] [PATCH v5 0/3] new API to free consumed buffers in Tx ring Billy McFall
2017-01-27 18:37 ` [dpdk-dev] [PATCH v5 1/3] ethdev: " Billy McFall
2017-02-27 13:48 ` Thomas Monjalon
2017-03-07 14:29 ` Billy McFall
2017-03-07 16:03 ` Thomas Monjalon
2017-03-09 15:49 ` Billy McFall
2017-03-09 17:11 ` Thomas Monjalon [this message]
2017-03-07 16:35 ` Mcnamara, John
2017-03-07 16:42 ` Mcnamara, John
2017-01-27 18:37 ` [dpdk-dev] [PATCH v5 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-02-27 13:49 ` Thomas Monjalon
2017-02-28 1:07 ` Lu, Wenzhuo
2017-01-27 18:38 ` [dpdk-dev] [PATCH v5 3/3] net/vhost: vHost " Billy McFall
2017-02-27 13:50 ` Thomas Monjalon
2017-02-28 6:41 ` Yuanhan Liu
2017-03-01 10:15 ` Maxime Coquelin
2017-03-07 21:59 ` [dpdk-dev] [PATCH v5 0/3] new API to free consumed buffers in Tx ring Thomas Monjalon
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 " Billy McFall
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 1/3] ethdev: " Billy McFall
2017-03-15 10:29 ` Olivier Matz
2017-03-15 15:01 ` Billy McFall
2017-03-15 10:30 ` Thomas Monjalon
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-03-13 3:17 ` Lu, Wenzhuo
2017-03-09 20:51 ` [dpdk-dev] [PATCH v6 3/3] net/vhost: vHost " Billy McFall
2017-03-15 10:27 ` Thomas Monjalon
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 0/3] new API to free consumed buffers in Tx ring Billy McFall
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 1/3] ethdev: " Billy McFall
2017-03-23 10:37 ` Olivier MATZ
2017-03-23 13:32 ` Billy McFall
2017-03-24 12:46 ` Olivier Matz
2017-03-24 13:18 ` Billy McFall
2017-03-24 13:30 ` Olivier Matz
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-03-15 18:02 ` [dpdk-dev] [PATCH v7 3/3] net/vhost: vHost " Billy McFall
2017-03-15 20:25 ` [dpdk-dev] [PATCH v7 0/3] new API to free consumed buffers in Tx ring Wiles, Keith
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 " Billy McFall
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 1/3] ethdev: " Billy McFall
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 2/3] net/e1000: e1000 igb support to free consumed buffers Billy McFall
2017-03-24 18:55 ` [dpdk-dev] [PATCH v8 3/3] net/vhost: vHost " Billy McFall
2017-03-27 15:20 ` [dpdk-dev] [PATCH v8 0/3] new API to free consumed buffers in Tx ring Thomas Monjalon
2017-04-19 16:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2146383.vtkpvASGrJ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bmcfall@redhat.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).