From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Owen Hilyard <ohilyard@iol.unh.edu>,
Lijuan Tu <lijuan.tu@intel.com>
Subject: Re: [PATCH v2] devtools: set DTS directory to format check
Date: Wed, 23 Nov 2022 16:56:14 +0100 [thread overview]
Message-ID: <2171904.72vocr9iq0@thomas> (raw)
In-Reply-To: <249765fcdb9f41ba8a993cdb8ce13e7c@pantheon.tech>
> The script was running on the current directory.
> If not in the DTS directory, it would re-format every Python files.
>
> A new positional argument is added to specify the directory to check.
> In most cases, the (new) default value should be enough.
>
> While updating argument handling,
> the usage is printed in case of wrong argument.
>
> The directory is also printed in headings, and a last heading is added for the summary part.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Reviewed-by: Owen Hilyard <ohilyard@iol.unh.edu>
> Reviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
> v2: add directory in headings and improve headings
> ---
>
> Nice touch with the headings. The patch looks and works great.
Thanks for the ideas.
> Tested-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Applied
prev parent reply other threads:[~2022-11-23 15:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 17:09 [PATCH] " Thomas Monjalon
2022-11-09 17:38 ` Owen Hilyard
2022-11-10 9:27 ` Juraj Linkeš
2022-11-10 10:26 ` Thomas Monjalon
2022-11-10 10:53 ` Juraj Linkeš
2022-11-11 10:06 ` Juraj Linkeš
2022-11-11 10:12 ` Thomas Monjalon
2022-11-23 11:22 ` [PATCH v2] " Thomas Monjalon
2022-11-23 13:41 ` Juraj Linkeš
2022-11-23 15:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2171904.72vocr9iq0@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=ohilyard@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).