From: Thomas Monjalon <thomas@monjalon.net>
To: ben.magistro@trinitycyber.com, stephen@networkplumber.org,
Ben Magistro <koncept1@gmail.com>,
Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] app/dumpcap: allow help/version without primary process
Date: Tue, 22 Feb 2022 11:03:06 +0100 [thread overview]
Message-ID: <21942374.BlLV05Wm1B@thomas> (raw)
In-Reply-To: <20220125032545.7704-1-koncept1@gmail.com>
25/01/2022 04:25, Ben Magistro:
> Currently dumpcap tries to initialize dpdk before parsing command line
> arguments, this makes it impossible to check version or help without
> having the primary process running already.
>
> Signed-off-by: Ben Magistro <koncept1@gmail.com>
> ---
> --- a/app/dumpcap/main.c
> +++ b/app/dumpcap/main.c
> @@ -781,8 +781,8 @@ int main(int argc, char **argv)
>
> progname = argv[0];
>
> - dpdk_init();
> parse_opts(argc, argv);
> + dpdk_init();
Stephen, Reshma, any comment?
next prev parent reply other threads:[~2022-02-22 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 3:25 Ben Magistro
2022-02-22 10:03 ` Thomas Monjalon [this message]
2022-03-08 8:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21942374.BlLV05Wm1B@thomas \
--to=thomas@monjalon.net \
--cc=ben.magistro@trinitycyber.com \
--cc=dev@dpdk.org \
--cc=koncept1@gmail.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).