From: Andy Green <andy@warmcat.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL on strncpy use
Date: Sat, 12 May 2018 09:17:38 +0800 [thread overview]
Message-ID: <21a607a0-cb6d-bb47-110a-1fc73474f91b@warmcat.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD0896E@IRSMSX108.ger.corp.intel.com>
On 05/11/2018 06:33 PM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
>> Sent: Friday, May 11, 2018 2:46 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL
>> on strncpy use
>>
>> /home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:
>> 76:2:error: ‘strncpy’ output may be truncated copying 8 bytes from a string of
>> length 8 [-Werror=stringop-truncation]
>> strncpy(name_pad, res->name, sizeof(name_pad));
>>
>> Signed-off-by: Andy Green <andy@warmcat.com>
>> ---
>> drivers/net/nfp/nfpcore/nfp_resource.c | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/nfp/nfpcore/nfp_resource.c
>> b/drivers/net/nfp/nfpcore/nfp_resource.c
>> index e1df2b2e1..dd41fa4de 100644
>> --- a/drivers/net/nfp/nfpcore/nfp_resource.c
>> +++ b/drivers/net/nfp/nfpcore/nfp_resource.c
>
> ...
>
>> - memset(name_pad, 0, NFP_RESOURCE_ENTRY_NAME_SZ);
>> - strncpy(name_pad, res->name, sizeof(name_pad));
>> + memset(name_pad, 0, sizeof(name_pad));
>> + strlcpy(name_pad, res->name, sizeof(name_pad));
>
> I think memset is not required, as strlcpy already null terminate the buffer.
It seems required to keep it, because of the exciting code just below it:
/* Search for a matching entry */
if (!memcmp(name_pad, NFP_RESOURCE_TBL_NAME "\0\0\0\0\0\0\0\0",
8)) {
printf("Grabbing device lock not supported\n");
return -EOPNOTSUPP;
}
-Andy
> ...
>
> Missing fixes line.
>
> Fixes: c7e9729da6b5 ("net/nfp: support CPP")
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
next prev parent reply other threads:[~2018-05-12 1:17 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 1:45 [dpdk-dev] [PATCH v4 00/18] Fix default build on gcc8.0.1 Andy Green
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 01/18] devtools/check-git: provide more generic grep pattern Andy Green
2018-05-11 8:11 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 02/18] net/nfp: solve buffer overflow Andy Green
2018-05-11 8:58 ` De Lara Guarch, Pablo
2018-05-11 10:13 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 03/18] bus/pci: replace strncpy dangerous code Andy Green
2018-05-11 8:17 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 04/18] bus/dpaa: solve inconsistent struct alignment Andy Green
2018-05-11 8:26 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 05/18] net/axgbe: solve broken eeprom string comp Andy Green
2018-05-11 10:09 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 06/18] net/nfp/nfpcore: solve strncpy misuse Andy Green
2018-05-11 10:26 ` De Lara Guarch, Pablo
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 07/18] net/nfp/nfpcore: off-by-one and no NUL on strncpy use Andy Green
2018-05-11 10:33 ` De Lara Guarch, Pablo
2018-05-12 1:17 ` Andy Green [this message]
2018-05-11 1:45 ` [dpdk-dev] [PATCH v4 08/18] net/nfp: don't memcpy out of source range Andy Green
2018-05-11 10:36 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 09/18] net/qede: strncpy length constant and NUL Andy Green
2018-05-11 10:43 ` De Lara Guarch, Pablo
2018-05-11 10:48 ` Andy Green
2018-05-11 12:48 ` De Lara Guarch, Pablo
2018-05-11 13:38 ` Andy Green
2018-05-11 15:14 ` De Lara Guarch, Pablo
2018-05-11 17:13 ` Shaikh, Shahed
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 10/18] net/qede: solve broken strncpy Andy Green
2018-05-11 10:47 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length Andy Green
2018-05-11 8:11 ` Andrew Rybchenko
2018-05-11 10:51 ` De Lara Guarch, Pablo
2018-05-12 1:21 ` Andy Green
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 12/18] net/sfc: solve strncpy size and NUL Andy Green
2018-05-11 8:13 ` Andrew Rybchenko
2018-05-11 10:55 ` De Lara Guarch, Pablo
2018-05-12 1:24 ` Andy Green
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot be aliased Andy Green
2018-05-11 15:39 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 14/18] net/vdev_netvsc: 3 x strncpy misuse Andy Green
2018-05-11 10:58 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 15/18] app: can't find include Andy Green
2018-05-11 11:04 ` De Lara Guarch, Pablo
2018-05-11 11:12 ` Andy Green
2018-05-11 13:20 ` De Lara Guarch, Pablo
2018-05-12 0:52 ` Andy Green
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 16/18] app/proc-info: sprintf overrun bug Andy Green
2018-05-11 12:26 ` De Lara Guarch, Pablo
2018-05-12 1:33 ` Andy Green
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 17/18] app/test-bbdev: strcpy ok for allocated string Andy Green
2018-05-11 12:55 ` De Lara Guarch, Pablo
2018-05-11 1:46 ` [dpdk-dev] [PATCH v4 18/18] " Andy Green
2018-05-11 13:02 ` De Lara Guarch, Pablo
2018-05-12 1:39 ` Andy Green
2018-05-11 11:14 ` [dpdk-dev] [PATCH v4 00/18] Fix default build on gcc8.0.1 Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21a607a0-cb6d-bb47-110a-1fc73474f91b@warmcat.com \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).