From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Wojciech Andralojc <wojciechx.andralojc@intel.com>
Cc: dev@dpdk.org, Marcel D Cornu <marcel.d.cornu@intel.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] examples/skeleton-cat: PQoS CAT and CDP, example of libpqos usage
Date: Fri, 11 Mar 2016 14:50:18 +0100 [thread overview]
Message-ID: <2207879.MgxKVmgPIQ@xps13> (raw)
In-Reply-To: <1457369659-101377-1-git-send-email-wojciechx.andralojc@intel.com>
2016-03-07 16:54, Wojciech Andralojc:
> +M: Tomasz Kantecki <tomasz.kantecki@intel.com>
> +F: examples/skeleton-cat/
> +F: doc/guides/sample_app_ug/skeleton-cat.rst
Please keep the alphabetical order.
> +Basic Forwarding sample application is a simple *skeleton* example of
> +a forwarding application. It has been extended to make use of CAT via extended
> +command line options and linking against the libpqos library.
The skeleton aims to show a minimal piece of code (but bigger than hello world).
For any other usage, I think the "l2fwd" name is more appropriate.
> +DIRS-y += skeleton-cat
It cannot be enabled everytime, because of the dependency.
We already have this problem with examples/vm_power_manager
and libvirt dependency. It must be solved by improving the build system.
In this case, we can simply use the variable PQOS_LIBRARY_PATH to
enable the build.
[...]
> +# Default location of PQoS library and includes,
> +# can be overridden by command line or environment
> +PQOS_INSTALL_PATH ?= /usr/local/
This default value is useless because we should detect the dependency
before trying to compile.
[...]
> +LDLIBS += $(PQOS_LIBRARY_PATH) \
Why this backslash?
next prev parent reply other threads:[~2016-03-11 13:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 13:26 [dpdk-dev] [PATCH] " Wojciech Andralojc
2016-02-26 15:07 ` [dpdk-dev] [PATCH v2] " Wojciech Andralojc
2016-03-07 14:34 ` Van Haaren, Harry
2016-03-07 16:54 ` [dpdk-dev] [PATCH v3] " Wojciech Andralojc
2016-03-07 17:19 ` Van Haaren, Harry
2016-03-11 13:50 ` Thomas Monjalon [this message]
2016-03-11 15:54 ` Kantecki, Tomasz
2016-03-11 16:03 ` Thomas Monjalon
2016-03-11 16:27 ` Bruce Richardson
2016-03-11 16:34 ` Kantecki, Tomasz
2016-03-11 16:38 ` Thomas Monjalon
2016-03-11 16:24 ` [dpdk-dev] [PATCH v4] " Wojciech Andralojc
2016-03-14 13:46 ` [dpdk-dev] [PATCH v5] examples/l2fwd-cat: " Wojciech Andralojc
2016-03-21 22:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2207879.MgxKVmgPIQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=marcel.d.cornu@intel.com \
--cc=tomasz.kantecki@intel.com \
--cc=wojciechx.andralojc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).