From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: fix the issue of port initialization failure
Date: Thu, 04 Feb 2016 09:43:35 +0100 [thread overview]
Message-ID: <2209475.O8bk1od0vQ@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A992CA8@SHSMSX104.ccr.corp.intel.com>
2016-02-04 00:50, Zhang, Helin:
> From: Richardson, Bruce
> > can you please add an appropriately "fixes" line to the patch, since the subject
> > explicitly calls it out as a bug-fix. Also, the words "the issue" in the subject can
> > be removed as they don't add value. It would also be worthwhile referencing
> > the adminq in the subject too, since that is the failure being reported. How
> > about:
> >
> > "i40e: fix adminq failure on port init"
>
> Oh, sorry, I forgot this patch.
> Firmware finally fixed it in FVL5, and we need to use new AQ commands for reading/writing some registers.
> So I will drop this patch. Thanks!
In such case, please mark it as "Rejected" in patchwork and self reply on the
mailing list to advertise it is dropped.
Thanks
next prev parent reply other threads:[~2016-02-04 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 5:32 Helin Zhang
2016-02-03 16:31 ` Bruce Richardson
2016-02-04 0:50 ` Zhang, Helin
2016-02-04 8:43 ` Thomas Monjalon [this message]
2016-02-05 1:21 ` Zhang, Helin
2016-02-05 1:20 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2209475.O8bk1od0vQ@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).