From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org, stable@dpdk.org,
Andrew Rybchenko <arybchenko@solarflare.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Jerin Jacob <jerinj@marvell.com>
Subject: Re: [dpdk-stable] [PATCH 1/2] doc: add PMD filtering features back
Date: Fri, 25 Oct 2019 15:23:28 +0200 [thread overview]
Message-ID: <2221169.ijzf7UYKas@xps> (raw)
In-Reply-To: <20191025125118.47189-1-ferruh.yigit@intel.com>
25/10/2019 14:51, Ferruh Yigit:
> Also filter definitions should be clarified more in the features
> documentation so that all PMDs can easily figure out to announce or
> not these filtering features, also users can understand better what to
> expect from this feature.
OK let's try to dig in some descriptions.
[...]
> +N-tuple filter
> +--------------
> +
> +Supports filtering on N-tuple values.
What is n-tuple? 3-tuple is enough?
> +Tunnel filter
> +-------------
> +
> +Supports tunnel filtering.
There are so many kinds of tunnels and filtering.
What is minimum to declare such feature?
Isn't it more relevant to list the supported tunnels?
> +Flexible filter
> +---------------
> +
> +Supports a flexible (non-tuple or Ethertype) filter.
This is meaningless and should be dropped for sure.
> +* **[implements] eth_dev_ops**: ``filter_ctrl:RTE_ETH_FILTER_FLEXIBLE``.
> +* **[related] API**: ``rte_eth_dev_filter_ctrl()``, ``rte_eth_dev_filter_supported()``.
You are referring to the deprecated API here and in other places.
> +Hash filter
> +-----------
> +
> +Supports Hash filtering.
Which hash?
> +Flow director
> +-------------
> +
> +Supports Flow Director style filtering to queues.
I think it is an Intel wording.
Could you describe it with networking words?
next prev parent reply other threads:[~2019-10-25 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 12:51 Ferruh Yigit
2019-10-25 13:23 ` Thomas Monjalon [this message]
2020-04-10 8:53 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2020-04-10 9:29 ` [dpdk-stable] [PATCH v2 " Ferruh Yigit
2020-04-10 12:22 ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2221169.ijzf7UYKas@xps \
--to=thomas@monjalon.net \
--cc=adrien.mazarguil@6wind.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).