From: Thomas Monjalon <thomas@monjalon.net>
To: Srikanth Yalavarthi <syalavarthi@marvell.com>
Cc: dev@dpdk.org, "Bruce Richardson" <bruce.richardson@intel.com>,
"David Marchand" <david.marchand@redhat.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>,
"Shivah Shankar Shankar Narayan Rao" <sshankarnara@marvell.com>,
"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>
Subject: Re: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script
Date: Wed, 08 Nov 2023 16:23:39 +0100 [thread overview]
Message-ID: <22362854.hxa6pUQ8Du@thomas> (raw)
In-Reply-To: <DS0PR18MB55024A7C833646D6DAB1192DAEA8A@DS0PR18MB5502.namprd18.prod.outlook.com>
08/11/2023 15:42, Srikanth Yalavarthi:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 08/11/2023 10:28, Srikanth Yalavarthi:
> > > As part of deprecating kmods meson option, 'kernel/linux'
> > > directory is removed from the repository.
> > >
> > > This patch removes non-existing 'kernel/linux' directory from
> > > linux_sources of build tags script.
> > >
> > > Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> >
> > If it is an old commit, you should probably add Cc: stable@dpdk.org You can
> > check with devtools/check-git-log.sh
>
> The fixes commit (a52d472c5c94) was merged after 23.11-rc0. check-git-log.sh script wasn't suggested to submit this to stable@dpdk.log
>
> My understanding is that Cc:stable@dpdk.org is need only if we need to backport the patch to older releases?
Your understanding is correct.
But here:
git describe a52d472c5c94
v23.07-183-ga52d472c5c
> > > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> >
> > You forgot the ack from Ferruh.
> >
> > Srikanth, you are sending a lot of patches, which is good :) but we will ask you
> > to make an effort on getting all details.
> > You may read again the contributor's guide again.
>
> Thanks. Apologies, Missed including Ack. Will take care of this.
No problem, it's always a pleasure to see newcomers becoming regular contributors.
next prev parent reply other threads:[~2023-11-08 15:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 4:44 [PATCH v1 " Srikanth Yalavarthi
2023-11-08 8:48 ` Ferruh Yigit
2023-11-08 9:29 ` [EXT] " Srikanth Yalavarthi
2023-11-08 9:28 ` [PATCH v2 " Srikanth Yalavarthi
2023-11-08 9:31 ` Morten Brørup
2023-11-08 11:24 ` Thomas Monjalon
2023-11-08 14:42 ` [EXT] " Srikanth Yalavarthi
2023-11-08 15:23 ` Thomas Monjalon [this message]
2023-11-28 10:57 ` Thomas Monjalon
2023-11-08 11:44 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22362854.hxa6pUQ8Du@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=sshankarnara@marvell.com \
--cc=stephen@networkplumber.org \
--cc=syalavarthi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).