From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ouyang, Changchun" <changchun.ouyang@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 00/26] Single virtio implementation
Date: Fri, 20 Feb 2015 19:06:28 +0100 [thread overview]
Message-ID: <2252127.u5a9G3bq7o@xps13> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F39ADCC@SHSMSX101.ccr.corp.intel.com>
> On 2/9/2015 9:14 AM, Ouyang, Changchun wrote:
> > This is the patch set for single virtio implementation.
> >
> > Why we need single virtio?
> > ============================
> > As we know currently there are at least 3 virtio PMD driver implementations:
> > A) lib/librte_pmd_virtio(refer as virtio A);
> > B) virtio_net_pmd by 6wind(refer as virtio B);
> > C) virtio by Brocade/vyatta(refer as virtio C);
> >
> > Integrating 3 implementations into one could reduce the maintaining cost and time,
> > in other hand, user don't need practice their application on 3 variant one by one to see
> > which one is the best for them;
> >
> > What's the status?
> > ====================
> > Currently virtio A has covered most features of virtio B except for using port io to get pci resource,
> > so there is a patch(17/22) to resolve it. But on the other hand there are a few differences between
> > virtio A and virtio C, it needs integrate features/codes of virtio C into virtio A.
> > This patch set bases on two original RFC patch sets from Stephen Hemminger[stephen@networkplumber.org]
> > Refer to [http://dpdk.org/ml/archives/dev/2014-August/004845.html ] for the original one.
> > This patch set also resolves some conflict with latest codes, removed duplicated codes, fix some
> > issues in original codes.
> >
> > What this patch set contains:
> > ===============================
> > 1) virtio: Rearrange resource initialization, it extracts a function to setup PCI resources;
> > 2) virtio: Use weaker barriers, as DPDK driver only has to deal with the case of running on PCI
> > and with SMP, In this case, the code can use the weaker barriers instead of using hard (fence)
> > barriers. This may help performance a bit;
> > 3) virtio: Allow starting with link down, other driver has similar behavior;
> > 4) virtio: Add support for Link State interrupt;
> > 5) ether: Add soft vlan encap/decap functions, it helps if HW don't support vlan strip;
> > 6) virtio: Use software vlan stripping;
> > 7) virtio: Remove unnecessary adapter structure;
> > 8) virtio: Remove redundant vq_alignment, as vq alignment is always 4K, so use constant when needed;
> > 9) virtio: Fix how states are handled during initialization, this is to match Linux kernel;
> > 10) virtio: Make vtpci_get_status a local function as it is used in one file;
> > 11) virtio: Check for packet headroom at compile time;
> > 12) virtio: Move allocation before initialization to avoid being stuck in middle of virtio init;
> > 13) virtio: Add support for vlan filtering;
> > 14) virtio: Add support for multiple mac addresses;
> > 15) virtio: Add ability to set MAC address;
> > 16) virtio: Free mbuf's with threshold, this makes its behavior more like ixgbe;
> > 17) virtio: Use port IO to get PCI resource for security reasons and match virtio-net-pmd;
> > 18) virtio: Fix descriptor index issue;
> > 19) ether: Fix vlan strip/insert issue;
> > 20) example/vhost: Avoid inserting vlan twice and guest and host;
> > 21) example/vhost: Add vlan-strip cmd line option to turn on/off vlan strip on host;
> > 22) virtio: Use soft vlan strip in mergeable Rx path, this makes it has consistent logic
> > with the normal Rx path.
> >
> > Changes in v2:
> > 23) virtio: Fix zero copy break issue, the vring should be ready before virtio PMD set
> > the status of DRIVER_OK;
> > 24) virtio: Remove unnecessary hotspots in data path.
> >
> > Changes in v3:
> > 25) virtio: Fix wmb issue;
> > 26) Fix one minor issue in patch 20, also fix its idention.
> >
> > Changes in v4:
> > 27) Fix updating vring descriptor index issue and memory barrier issue;
> > 28) Reslove comments for patch 17.
> >
> > Changchun Ouyang (10):
> > virtio: Use port IO to get PCI resource.
> > virtio: Fix descriptor index issue
> > ether: Fix vlan strip/insert issue
> > example/vhost: Avoid inserting vlan twice
> > example/vhost: Add vlan-strip cmd line option
> > virtio: Use soft vlan strip in mergeable Rx path
> > virtio: Fix zero copy break issue
> > virtio: Remove hotspots
> > virtio: Fix wmb issue
> > virtio: Fix updating vring descriptor index issue
> >
> > Stephen Hemminger (16):
> > virtio: Rearrange resource initialization
> > virtio: Use weaker barriers
> > virtio: Allow starting with link down
> > virtio: Add support for Link State interrupt
> > ether: Add soft vlan encap/decap functions
> > virtio: Use software vlan stripping
> > virtio: Remove unnecessary adapter structure
> > virtio: Remove redundant vq_alignment
> > virtio: Fix how states are handled during initialization
> > virtio: Make vtpci_get_status local
> > virtio: Check for packet headroom at compile time
> > virtio: Move allocation before initialization
> > virtio: Add support for vlan filtering
> > virtio: Add suport for multiple mac addresses
> > virtio: Add ability to set MAC address
> > virtio: Free mbuf's with threshold
>
> Acked-by Huawei Xie <huawei.xie@intel.com>
Applied, thanks.
The patches which were fixing previous ones have been merged.
The virtio-net-pmd extension (out of tree) should be deprecated now.
prev parent reply other threads:[~2015-02-20 18:07 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 5:15 [dpdk-dev] [PATCH 00/22] " Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 01/22] virtio: Rearrange resource initialization Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 02/22] virtio: Use weaker barriers Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 03/22] virtio: Allow starting with link down Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 04/22] virtio: Add support for Link State interrupt Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 05/22] ether: Add soft vlan encap/decap functions Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 06/22] virtio: Use software vlan stripping Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 07/22] virtio: Remove unnecessary adapter structure Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 08/22] virtio: Remove redundant vq_alignment Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 09/22] virtio: Fix how states are handled during initialization Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 10/22] virtio: Make vtpci_get_status local Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 11/22] virtio: Check for packet headroom at compile time Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 12/22] virtio: Move allocation before initialization Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 13/22] virtio: Add support for vlan filtering Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 14/22] virtio: Add suport for multiple mac addresses Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 15/22] virtio: Add ability to set MAC address Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 16/22] virtio: Free mbuf's with threshold Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 17/22] virtio: Use port IO to get PCI resource Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 18/22] virtio: Fix descriptor index issue Ouyang Changchun
2015-01-15 16:54 ` Stephen Hemminger
2015-01-16 0:55 ` Ouyang, Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 19/22] ether: Fix vlan strip/insert issue Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 20/22] example/vhost: Avoid inserting vlan twice Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 21/22] example/vhost: Add vlan-strip cmd line option Ouyang Changchun
2015-01-15 5:15 ` [dpdk-dev] [PATCH 22/22] virtio: Use soft vlan strip in mergeable Rx path Ouyang Changchun
2015-01-15 16:55 ` Stephen Hemminger
2015-01-16 0:56 ` Ouyang, Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 00/24] Single virtio implementation Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 01/24] virtio: Rearrange resource initialization Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers Ouyang Changchun
2015-01-27 7:03 ` Xie, Huawei
2015-01-27 9:58 ` Stephen Hemminger
2015-01-27 16:16 ` Xie, Huawei
2015-01-28 6:12 ` Ouyang, Changchun
2015-01-27 7:56 ` Xie, Huawei
2015-01-27 8:04 ` Ouyang, Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 03/24] virtio: Allow starting with link down Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 04/24] virtio: Add support for Link State interrupt Ouyang Changchun
2015-01-27 9:04 ` Xie, Huawei
2015-01-27 10:00 ` Stephen Hemminger
2015-01-28 3:03 ` Ouyang, Changchun
2015-01-28 15:11 ` Stephen Hemminger
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 05/24] ether: Add soft vlan encap/decap functions Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 06/24] virtio: Use software vlan stripping Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 07/24] virtio: Remove unnecessary adapter structure Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 08/24] virtio: Remove redundant vq_alignment Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 09/24] virtio: Fix how states are handled during initialization Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 10/24] virtio: Make vtpci_get_status local Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 11/24] virtio: Check for packet headroom at compile time Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 12/24] virtio: Move allocation before initialization Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 13/24] virtio: Add support for vlan filtering Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 14/24] virtio: Add suport for multiple mac addresses Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 15/24] virtio: Add ability to set MAC address Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 16/24] virtio: Free mbuf's with threshold Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 17/24] virtio: Use port IO to get PCI resource Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 18/24] virtio: Fix descriptor index issue Ouyang Changchun
2015-01-27 2:35 ` [dpdk-dev] [PATCH v2 19/24] ether: Fix vlan strip/insert issue Ouyang Changchun
2015-01-27 2:36 ` [dpdk-dev] [PATCH v2 20/24] example/vhost: Avoid inserting vlan twice Ouyang Changchun
2015-01-27 2:36 ` [dpdk-dev] [PATCH v2 21/24] example/vhost: Add vlan-strip cmd line option Ouyang Changchun
2015-01-27 2:36 ` [dpdk-dev] [PATCH v2 22/24] virtio: Use soft vlan strip in mergeable Rx path Ouyang Changchun
2015-01-27 2:36 ` [dpdk-dev] [PATCH v2 23/24] virtio: Fix zero copy break issue Ouyang Changchun
2015-01-27 2:36 ` [dpdk-dev] [PATCH v2 24/24] virtio: Remove hotspots Ouyang Changchun
2015-01-27 3:06 ` [dpdk-dev] [PATCH v2 00/24] Single virtio implementation Matthew Hall
2015-01-27 3:42 ` Wiles, Keith
2015-01-27 9:41 ` Matthew Hall
2015-01-27 10:02 ` Stephen Hemminger
2015-01-27 18:59 ` Matthew Hall
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 00/25] " Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 01/25] virtio: Rearrange resource initialization Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 02/25] virtio: Use weaker barriers Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 03/25] virtio: Allow starting with link down Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 04/25] virtio: Add support for Link State interrupt Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 05/25] ether: Add soft vlan encap/decap functions Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 06/25] virtio: Use software vlan stripping Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 07/25] virtio: Remove unnecessary adapter structure Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 08/25] virtio: Remove redundant vq_alignment Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 09/25] virtio: Fix how states are handled during initialization Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 10/25] virtio: Make vtpci_get_status local Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 11/25] virtio: Check for packet headroom at compile time Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 12/25] virtio: Move allocation before initialization Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 13/25] virtio: Add support for vlan filtering Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 14/25] virtio: Add suport for multiple mac addresses Ouyang Changchun
2015-01-29 7:23 ` [dpdk-dev] [PATCH v3 15/25] virtio: Add ability to set MAC address Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 16/25] virtio: Free mbuf's with threshold Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 17/25] virtio: Use port IO to get PCI resource Ouyang Changchun
2015-01-29 23:14 ` Thomas Monjalon
2015-02-04 1:31 ` Ouyang, Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 18/25] virtio: Fix descriptor index issue Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 19/25] ether: Fix vlan strip/insert issue Ouyang Changchun
2015-02-04 10:54 ` Xie, Huawei
2015-02-05 0:54 ` Ouyang, Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 20/25] example/vhost: Avoid inserting vlan twice Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 21/25] example/vhost: Add vlan-strip cmd line option Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 22/25] virtio: Use soft vlan strip in mergeable Rx path Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 23/25] virtio: Fix zero copy break issue Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 24/25] virtio: Remove hotspots Ouyang Changchun
2015-01-29 7:24 ` [dpdk-dev] [PATCH v3 25/25] virtio: Fix wmb issue Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 00/26] Single virtio implementation Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 01/26] virtio: Rearrange resource initialization Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 02/26] virtio: Use weaker barriers Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 03/26] virtio: Allow starting with link down Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 04/26] virtio: Add support for Link State interrupt Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 05/26] ether: Add soft vlan encap/decap functions Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 06/26] virtio: Use software vlan stripping Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 07/26] virtio: Remove unnecessary adapter structure Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 08/26] virtio: Remove redundant vq_alignment Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 09/26] virtio: Fix how states are handled during initialization Ouyang Changchun
2015-02-09 1:13 ` [dpdk-dev] [PATCH v4 10/26] virtio: Make vtpci_get_status local Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 11/26] virtio: Check for packet headroom at compile time Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 12/26] virtio: Move allocation before initialization Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 13/26] virtio: Add support for vlan filtering Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 14/26] virtio: Add suport for multiple mac addresses Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 15/26] virtio: Add ability to set MAC address Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 16/26] virtio: Free mbuf's with threshold Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 17/26] virtio: Use port IO to get PCI resource Ouyang Changchun
2015-02-11 4:32 ` Stephen Hemminger
2015-02-11 4:50 ` Ouyang, Changchun
2015-02-11 7:29 ` Vincent JARDIN
2015-02-11 13:50 ` Stephen Hemminger
2015-02-11 14:16 ` Thomas Monjalon
2015-02-12 0:52 ` Ouyang, Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 18/26] virtio: Fix descriptor index issue Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 19/26] ether: Fix vlan strip/insert issue Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 20/26] example/vhost: Avoid inserting vlan twice Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 21/26] example/vhost: Add vlan-strip cmd line option Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 22/26] virtio: Use soft vlan strip in mergeable Rx path Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 23/26] virtio: Fix zero copy break issue Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 24/26] virtio: Remove hotspots Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 25/26] virtio: Fix wmb issue Ouyang Changchun
2015-02-09 1:14 ` [dpdk-dev] [PATCH v4 26/26] virtio: Fix updating vring descriptor index issue Ouyang Changchun
2015-02-17 6:04 ` [dpdk-dev] [PATCH v4 00/26] Single virtio implementation Xie, Huawei
2015-02-20 18:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2252127.u5a9G3bq7o@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).