From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ori Kam <orika@nvidia.com>, Gregory Etelson <getelson@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Maayan Kashani <mkashani@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH v6] ethdev: add indirect list flow action
Date: Wed, 31 May 2023 12:24:47 +0100 [thread overview]
Message-ID: <22600b4b-c7dd-f5ef-5f8e-40e7ebc115b0@amd.com> (raw)
In-Reply-To: <MW2PR12MB4666C32182C351CD318FF6D0D64A9@MW2PR12MB4666.namprd12.prod.outlook.com>
On 5/29/2023 7:14 AM, Ori Kam wrote:
> Hi gregory,
>
>> -----Original Message-----
>> From: Gregory Etelson <getelson@nvidia.com>
>> Sent: Sunday, May 28, 2023 6:44 PM
>>
>> Indirect API creates a shared flow action with unique action handle.
>> Flow rules can access the shared flow action and resources related to
>> that action through the indirect action handle.
>> In addition, the API allows to update existing shared flow action
>> configuration. After the update completes, new action configuration
>> is available to all flows that reference that shared action.
>>
>> Indirect actions list expands the indirect action API:
>> • Indirect action list creates a handle for one or several
>> flow actions, while legacy indirect action handle references
>> single action only.
>> Input flow actions arranged in END terminated list.
>> • Flow rule can provide rule specific configuration parameters to
>> existing shared handle.
>> Updates of flow rule specific configuration will not change the base
>> action configuration.
>> Base action configuration was set during the action creation.
>>
>> Indirect action list handle defines 2 types of resources:
>> • Mutable handle resource can be changed during handle lifespan.
>> • Immutable handle resource value is set during handle creation
>> and cannot be changed.
>>
>> There are 2 types of mutable indirect handle contexts:
>> • Action mutable context is always shared between all flows
>> that referenced indirect actions list handle.
>> Action mutable context can be changed by explicit invocation
>> of indirect handle update function.
>> • Flow mutable context is private to a flow.
>> Flow mutable context can be updated by indirect list handle
>> flow rule configuration.
>>
>> flow 1:
>> / indirect handle H conf C1 /
>> | |
>> | |
>> | | flow 2:
>> | | / indirect handle H conf C2 /
>> | | | |
>> | | | |
>> | | | |
>> =========================================================
>> ^ | | | |
>> | | V | V
>> | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~
>> | flow mutable flow mutable
>> | context 1 context 2
>> | ~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~
>> indirect | | |
>> action | | |
>> context | V V
>> | -----------------------------------------------------
>> | action mutable context
>> | -----------------------------------------------------
>> v action immutable context
>> =========================================================
>>
>> Indirect action types - immutable, action / flow mutable, are mutually
>> exclusive and depend on the action definition.
>> For example:
>> • Indirect METER_MARK policy is immutable action member and profile is
>> action mutable action member.
>> • Indirect METER_MARK flow action defines init_color as flow mutable
>> member.
>> • Indirect QUOTA flow action does not define flow mutable members.
>>
>> If indirect list handle was created from a list of actions
>> A1 / A2 ... An / END
>> indirect list flow action can update Ai flow mutable context in the
>> action configuration parameter.
>> Indirect list action configuration is and array [C1, C2, .., Cn]
>> where Ci corresponds to Ai in the action handle source.
>> Ci configuration element points Ai flow mutable update, or it's NULL
>> if Ai has no flow mutable update.
>> Indirect list action configuration can be NULL if the action
>> has no flow mutable updates.
>>
>> Template API:
>>
>> Action template format:
>>
>> template .. indirect_list handle Htmpl conf Ctmpl ..
>> mask .. indirect_list handle Hmask conf Cmask ..
>>
>> 1 If Htmpl was masked (Hmask != 0), it will be fixed in that template.
>> Otherwise, indirect action value is set in a flow rule.
>>
>> 2 If Htmpl and Ctmpl[i] were masked (Hmask !=0 and Cmask[i] != 0),
>> Htmpl's Ai action flow mutable context fill be updated to
>> Ctmpl[i] values and will be fixed in that template.
>>
>> Flow rule format:
>>
>> actions .. indirect_list handle Hflow conf Cflow ..
>>
>> 3 If Htmpl was not masked in actions template, Hflow references an
>> action of the same type as Htmpl.
>>
>> 4 Cflow[i] updates handle's Ai flow mutable configuration if
>> the Ci was not masked in action template.
>>
>> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
>> ---
>
> Acked-by: Ori Kam <orika@nvidia.com>
>
Applied to dpdk-next-net/main, thanks.
(checkpatch warnings fixed while merging.)
prev parent reply other threads:[~2023-05-31 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 17:21 [PATCH] " Gregory Etelson
2023-05-02 15:09 ` [RFC PATCH v2] " Gregory Etelson
2023-05-02 16:00 ` Ivan Malov
2023-05-03 7:05 ` Gregory Etelson
2023-05-07 9:50 ` [RFC PATCH v3] " Gregory Etelson
2023-05-17 16:57 ` Ori Kam
2023-05-18 18:18 ` Gregory Etelson
2023-05-19 11:59 ` [PATCH v4] " Gregory Etelson
2023-05-24 17:46 ` Ori Kam
2023-05-25 8:14 ` Gregory Etelson
2023-05-25 8:12 ` [PATCH v5 1/2] " Gregory Etelson
2023-05-25 8:12 ` [PATCH v5 2/2] ethdev: add indirect list METER_MARK update structures Gregory Etelson
2023-05-28 14:07 ` Ori Kam
2023-05-29 4:03 ` Gregory Etelson
2023-05-28 15:43 ` [PATCH v6] ethdev: add indirect list flow action Gregory Etelson
2023-05-29 6:14 ` Ori Kam
2023-05-31 11:24 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22600b4b-c7dd-f5ef-5f8e-40e7ebc115b0@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).