From: Yongseok Koh <yskoh@mellanox.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Raslan Darawsheh <rasland@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability
Date: Tue, 3 Oct 2017 06:53:32 +0000 [thread overview]
Message-ID: <2260C792-E8AD-4CDE-81E5-7B607ECA9FE5@mellanox.com> (raw)
In-Reply-To: <18261cc6-ada3-59de-c200-91ea80dcf7fd@solarflare.com>
> On Oct 2, 2017, at 11:40 PM, Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>
> On 10/03/2017 09:33 AM, Raslan Darawsheh wrote:
>> Add a new offload capability flag for Rx HW
>> timestamp and enabling/disabling this via rte_eth_rxmode.
>>
>> Signed-off-by: Raslan Darawsheh
>> <rasland@mellanox.com>
>>
>> ---
>> This patch should be applied after after this series:
>>
>> http://dpdk.org/dev/patchwork/patch/29368/
>>
>> ---
>> doc/guides/nics/features.rst | 11 +++++++++++
>> lib/librte_ether/rte_ethdev.c | 6 ++++++
>> lib/librte_ether/rte_ethdev.h | 5 ++++-
>> 3 files changed, 21 insertions(+), 1 deletion(-)
>>
>
> <...>
>
>> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
>> index ffd2ee5..bd63730 100644
>> --- a/lib/librte_ether/rte_ethdev.h
>> +++ b/lib/librte_ether/rte_ethdev.h
>> @@ -368,7 +368,8 @@ struct rte_eth_rxmode {
>> jumbo_frame : 1, /**< Jumbo Frame Receipt enable. */
>> hw_strip_crc : 1, /**< Enable CRC stripping by hardware. */
>> enable_scatter : 1, /**< Enable scatter packets rx handler */
>> - enable_lro : 1; /**< Enable LRO */
>> + enable_lro : 1, /**< Enable LRO */
>> + hw_timestamp : 1; /**< Enable HW timestamp */
>>
>
> The code is definitely not rebased on top of a new Rx offload API patch which adds
> ignore_offload_bitfield : 1;
> exactly in this place.
Hi Andrew,
Did you check Shahaf's email regarding this? Looks like Shahaf suggests keeping it as is for now.
> On Sep 30, 2017, at 11:44 PM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> >[1] http://dpdk.org/ml/archives/dev/2017-September/076872.html
>
> I agree it should be on top of [1].
> Unfortunately since the PMDs will move to the new API only on 18.02, and in the current state Rx offloads are disabled by default, there will be no way to enable this feature without a dedicated bit.
>
> So my suggestion is to keep the timestamp bit on rxmode, and to update the convert function introduced on [1]. This bit will be removed along with the entire bit-field array once the old offloads API will be deprecated.
Thanks,
Yongseok
next prev parent reply other threads:[~2017-10-03 6:53 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 13:46 [dpdk-dev] [PATCH 1/3] ethdev: expose Rx hardware timestamp Raslan Darawsheh
2017-08-22 13:46 ` [dpdk-dev] [PATCH 2/3] app/testpmd: add Rx timestamp in testpmd Raslan Darawsheh
2017-08-22 13:46 ` [dpdk-dev] [PATCH 3/3] net/mlx5: add hardware timestamp Raslan Darawsheh
2017-08-23 15:02 ` Nélio Laranjeiro
2017-08-24 7:46 ` [dpdk-dev] [PATCH v2 1/3] ethdev: expose Rx " Raslan Darawsheh
2017-08-24 7:46 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: add Rx timestamp in testpmd Raslan Darawsheh
2017-08-24 13:49 ` Nélio Laranjeiro
2017-08-24 7:46 ` [dpdk-dev] [PATCH v2 3/3] net/mlx5: add hardware timestamp Raslan Darawsheh
2017-08-24 14:01 ` Nélio Laranjeiro
2017-08-24 13:47 ` [dpdk-dev] [PATCH v2 1/3] ethdev: expose Rx " Nélio Laranjeiro
2017-09-28 16:48 ` [dpdk-dev] [PATCH v3 1/3] ethdev: add Rx HW timestamp capability Raslan Darawsheh
2017-09-28 16:48 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-09-28 16:48 ` [dpdk-dev] [PATCH v3 3/3] net/mlx5: " Raslan Darawsheh
2017-09-29 7:25 ` [dpdk-dev] [PATCH v3 1/3] ethdev: add Rx HW timestamp capability Andrew Rybchenko
2017-10-01 6:44 ` Shahaf Shuler
2017-10-02 14:50 ` [dpdk-dev] [PATCH " Raslan Darawsheh
2017-10-02 14:50 ` [dpdk-dev] [PATCH 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-02 14:50 ` [dpdk-dev] [PATCH 3/3] net/mlx5: " Raslan Darawsheh
2017-10-02 18:48 ` [dpdk-dev] [PATCH 1/3] ethdev: add Rx HW timestamp capability Ferruh Yigit
2017-10-03 0:39 ` Yongseok Koh
2017-10-03 6:33 ` [dpdk-dev] [PATCH v5 " Raslan Darawsheh
2017-10-03 6:33 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-03 6:33 ` [dpdk-dev] [PATCH v5 3/3] net/mlx5: " Raslan Darawsheh
2017-10-03 6:40 ` [dpdk-dev] [PATCH v5 1/3] ethdev: add Rx HW timestamp capability Andrew Rybchenko
2017-10-03 6:53 ` Yongseok Koh [this message]
2017-10-03 7:24 ` Andrew Rybchenko
2017-10-03 11:00 ` [dpdk-dev] [PATCH v6 " Raslan Darawsheh
2017-10-03 11:00 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-05 23:11 ` Yongseok Koh
2017-10-03 11:00 ` [dpdk-dev] [PATCH v6 3/3] net/mlx5: " Raslan Darawsheh
2017-10-05 23:23 ` Yongseok Koh
2017-10-08 8:24 ` [dpdk-dev] [PATCH v7 1/3] ethdev: add Rx HW timestamp capability Raslan Darawsheh
2017-10-08 8:24 ` [dpdk-dev] [PATCH v7 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-08 8:24 ` [dpdk-dev] [PATCH v7 3/3] net/mlx5: " Raslan Darawsheh
2017-10-09 19:17 ` Ferruh Yigit
2017-10-10 7:45 ` [dpdk-dev] [PATCH v8 1/3] ethdev: add Rx HW timestamp capability Raslan Darawsheh
2017-10-10 7:45 ` [dpdk-dev] [PATCH v8 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-10 7:45 ` [dpdk-dev] [PATCH v8 3/3] net/mlx5: " Raslan Darawsheh
2017-10-10 13:33 ` [dpdk-dev] [PATCH v8 1/3] ethdev: add Rx HW timestamp capability Yongseok Koh
2017-10-10 14:37 ` [dpdk-dev] [PATCH v9 " Raslan Darawsheh
2017-10-10 14:37 ` [dpdk-dev] [PATCH v9 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-10 14:37 ` [dpdk-dev] [PATCH v9 3/3] net/mlx5: " Raslan Darawsheh
2017-10-10 14:40 ` Yongseok Koh
2017-10-11 1:14 ` [dpdk-dev] [PATCH v9 1/3] ethdev: add Rx HW timestamp capability Ferruh Yigit
2017-10-11 1:22 ` Yongseok Koh
2017-10-11 1:30 ` Ferruh Yigit
2017-10-04 5:57 ` [dpdk-dev] [PATCH v6 " Shahaf Shuler
2017-10-06 0:54 ` Ferruh Yigit
2017-10-02 14:01 ` [dpdk-dev] [PATCH " Raslan Darawsheh
2017-10-02 14:01 ` [dpdk-dev] [PATCH 2/3] app/testpmd: add Rx HW timestamp Raslan Darawsheh
2017-10-02 14:01 ` [dpdk-dev] [PATCH 3/3] net/mlx5: " Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2260C792-E8AD-4CDE-81E5-7B607ECA9FE5@mellanox.com \
--to=yskoh@mellanox.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).