From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 4/7] vhost: fold common message handlers
Date: Wed, 24 Aug 2016 10:01:25 +0200 [thread overview]
Message-ID: <2267ccd6-e695-eae6-1f95-58e1269da965@redhat.com> (raw)
In-Reply-To: <1471510123-4984-5-git-send-email-yuanhan.liu@linux.intel.com>
On 08/18/2016 10:48 AM, Yuanhan Liu wrote:
> Due to history reason (that we have 2 vhost implementations), some
> messages are handled in two calls: vhost specific implementation
> handles it first and then invoke the common one to do another handling.
>
> We have one implementation only now, we could write one method for
> each message. Here fold those common handles to corresponding vhost
> user handler.
>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
> lib/librte_vhost/vhost_user.c | 115 ++++++++++++------------------------------
> 1 file changed, 31 insertions(+), 84 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2016-08-24 8:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 8:48 [dpdk-dev] [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring Yuanhan Liu
2016-08-18 8:48 ` [dpdk-dev] [PATCH 1/7] vhost: remove vhost-cuse Yuanhan Liu
2016-08-22 13:46 ` Thomas Monjalon
2016-08-22 14:09 ` Yuanhan Liu
2016-08-29 6:45 ` Yuanhan Liu
2016-08-24 7:42 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 2/7] vhost: remove sub source dir Yuanhan Liu
2016-08-24 7:44 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 3/7] vhost: refactor source code structure Yuanhan Liu
2016-08-24 7:53 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 4/7] vhost: fold common message handlers Yuanhan Liu
2016-08-24 8:01 ` Maxime Coquelin [this message]
2016-08-18 8:48 ` [dpdk-dev] [PATCH 5/7] vhost: unify function names Yuanhan Liu
2016-08-24 8:02 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 6/7] vhost: get device once Yuanhan Liu
2016-08-24 8:04 ` Maxime Coquelin
2016-08-18 8:48 ` [dpdk-dev] [PATCH 7/7] vhost: simplify features set/get Yuanhan Liu
2016-08-24 8:11 ` Maxime Coquelin
2016-08-25 3:03 ` Yuanhan Liu
2016-08-25 7:18 ` Maxime Coquelin
2016-08-25 8:36 ` Xu, Qian Q
2016-08-25 9:10 ` Maxime Coquelin
2016-08-26 4:15 ` Yuanhan Liu
2016-08-24 7:30 ` [dpdk-dev] [PATCH 0/7] vhost: vhost-cuse removal and code path refactoring Xu, Qian Q
2016-08-24 7:47 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2267ccd6-e695-eae6-1f95-58e1269da965@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).