From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize the VXLAN sample
Date: Mon, 22 Jun 2015 09:49:27 +0200 [thread overview]
Message-ID: <2269442.FSZeuyxEr5@xps13> (raw)
In-Reply-To: <1434589417-5395-2-git-send-email-jijiang.liu@intel.com>
2015-06-18 09:03, Jijiang Liu:
> This sample uses the basic virtio devices management function from the vHost example, which includes virtio device creation, destroying and maintenance.
Please wrap commit message to about 72 characters.
https://github.com/erlang/otp/wiki/Writing-good-commit-messages
https://git-scm.com/book/ch5-2.html
typo in Makefile:
overriden -> overridden
There are 2 functions where ret is incremented but never initialized:
examples/tep_termination/main.c:473:6: error: ‘ret’ may be used uninitialized in this function
examples/tep_termination/main.c:536:8: error: ‘ret’ may be used uninitialized in this function
Making a patch buildable with recent GCC and clang is the minimum before submitting it.
next prev parent reply other threads:[~2015-06-22 7:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 1:03 [dpdk-dev] [PATCH v4 00/10] Add a " Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 01/10] examples/tep_termination:initialize the " Jijiang Liu
2015-06-22 7:49 ` Thomas Monjalon [this message]
2015-06-22 13:55 ` Liu, Jijiang
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 02/10] examples/tep_termination:define the basic VXLAN port information Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 03/10] examples/tep_termination:add the pluggable structures for VXLAN packet processing Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 04/10] examples/tep_termination:implement " Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 05/10] examples/tep_termination:add UDP port configuration for UDP tunneling packet Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 06/10] examples/tep_termination:add tunnel filter type configuration Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 07/10] examples/tep_termination:add Tx checksum offload configuration for inner header Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 08/10] examples/tep_termination:add TSO offload configuration Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 09/10] examples/tep_termination:add bad Rx checksum statistics of inner IP and L4 Jijiang Liu
2015-06-18 1:03 ` [dpdk-dev] [PATCH v4 10/10] examples/tep_termination:add the configuration for encapsulation and the decapsulation Jijiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2269442.FSZeuyxEr5@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jijiang.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).