From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix plugindir processing to be filesystem agnostic
Date: Mon, 23 Nov 2015 14:54:28 +0100 [thread overview]
Message-ID: <2288290.JHOQINxEtF@xps13> (raw)
In-Reply-To: <5652FB92.2050107@redhat.com>
2015-11-23 13:42, Panu Matilainen:
> On 11/23/2015 12:41 PM, Thomas Monjalon wrote:
> > 2015-11-23 08:04, Panu Matilainen:
> >> On 11/20/2015 06:38 PM, David Marchand wrote:
> >>> It looks like you would skip the symbolic links while you were not before.
> >>> Intended ?
> >>
> >> Intended. We want to accept symlinks in the driver directory, but the
> >> actual drivers are always regular files.
> >
> > No we use symbolic links:
> > http://dpdk.org/browse/dpdk/commit/mk/rte.lib.mk?id=133b75923
> > http://dpdk.org/browse/dpdk/tree/mk/rte.lib.mk#n170
>
> Those symlinks eventually point to the actual drivers which are always
> regular files (and not for example directories), that is the point.
> Please apply.
Yes
> > On the same topic, you've added a check in 9f8eb1d9:
> > + if (stat(solib->name, &sb) == -1) {
> > + RTE_LOG(ERR, EAL, "Invalid plugin specified: %s: %s\n",
> > + solib->name, strerror(errno));
> >
> > It is a regression because we cannot anymore load a plugin from
> > LD_LIBRARY_PATH without specifying its full path.
> > It can be tested with scripts/test-null.sh.
> > How do you suggest to fix it?
>
> My first and foremost thought is regret over messing with -d at all,
> instead of keeping with the original plan of a new -D option for
> directories. Supporting directories with -d opened up all these annoying
> little issues that did not exist in the original plan, and lost the
> ability to disable/override the default plugindir.
I keep thinking having an unique option is a good thing.
If disabling the default directory is needed, we can imagine a special
syntax like -d-
Thanks for your work.
> I suppose the fix is to only use a successful stat to determine if
> something is a directory and feed everything else to dlopen() which will
> then fail on its own if file is not existent.
Yes sounds good.
> I'll send a separate patch for the regression.
Thanks
next prev parent reply other threads:[~2015-11-23 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 6:45 Panu Matilainen
2015-11-20 16:38 ` David Marchand
2015-11-23 6:04 ` Panu Matilainen
2015-11-23 10:41 ` Thomas Monjalon
2015-11-23 11:42 ` Panu Matilainen
2015-11-23 13:54 ` Thomas Monjalon [this message]
2015-11-23 15:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2288290.JHOQINxEtF@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).