From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH 08/10] lpm6: fix compilation with -Og
Date: Fri, 6 Oct 2017 01:18:00 +0100 [thread overview]
Message-ID: <228abb94-4939-8425-9451-2fb57fd1c567@intel.com> (raw)
In-Reply-To: <20170911151333.5727-9-olivier.matz@6wind.com>
On 9/11/2017 4:13 PM, Olivier Matz wrote:
> The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following
> error:
>
> CC rte_lpm6.o
> rte_lpm6.c: In function ‘rte_lpm6_add_v1705’:
> rte_lpm6.c:442:11: error: ‘tbl_next’ may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
> if (!tbl[tbl_index].valid) {
> ^
> rte_lpm6.c:521:29: note: ‘tbl_next’ was declared here
> struct rte_lpm6_tbl_entry *tbl_next;
> ^~~~~~~~
>
> This is a false positive from gcc. Fix it by initializing tbl_next
> to NULL.
This is hard to trace, and it seems there is a way to have it, not sure
practically possible:
rte_lpm6_add_v1705
add_step
if (depth <= bits_covered) {
...
return 0 <--- so tbl_next stays untouched.
tbl = tbl_next
add_step
tbl[tbl_index]
So same comment as previous, if there is a practically available path,
this patch makes it harder to find by hiding compiler warning, so adding
maintainer for decision.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> lib/librte_lpm/rte_lpm6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c
> index b4a7df348..f9496fe1b 100644
> --- a/lib/librte_lpm/rte_lpm6.c
> +++ b/lib/librte_lpm/rte_lpm6.c
> @@ -518,7 +518,7 @@ rte_lpm6_add_v1705(struct rte_lpm6 *lpm, uint8_t *ip, uint8_t depth,
> uint32_t next_hop)
> {
> struct rte_lpm6_tbl_entry *tbl;
> - struct rte_lpm6_tbl_entry *tbl_next;
> + struct rte_lpm6_tbl_entry *tbl_next = NULL;
> int32_t rule_index;
> int status;
> uint8_t masked_ip[RTE_LPM6_IPV6_ADDR_SIZE];
>
next prev parent reply other threads:[~2017-10-06 0:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 15:13 [dpdk-dev] [PATCH 00/10] " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 01/10] net/bnxt: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 02/10] net/qede: " Olivier Matz
2017-09-11 18:22 ` Patil, Harish
2017-09-11 15:13 ` [dpdk-dev] [PATCH 03/10] net/virtio: " Olivier Matz
2017-10-05 23:17 ` Ferruh Yigit
2017-10-05 23:28 ` Ferruh Yigit
2017-10-06 6:43 ` Maxime Coquelin
2017-10-06 18:43 ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 04/10] net/i40e: " Olivier Matz
2017-10-05 23:24 ` Ferruh Yigit
2017-10-11 6:20 ` Wu, Jingjing
2017-10-11 7:52 ` Olivier MATZ
2017-09-11 15:13 ` [dpdk-dev] [PATCH 05/10] uio: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 06/10] cmdline: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 07/10] metrics: " Olivier Matz
2017-09-11 15:13 ` [dpdk-dev] [PATCH 08/10] lpm6: " Olivier Matz
2017-10-06 0:18 ` Ferruh Yigit [this message]
2017-10-26 10:42 ` Bruce Richardson
2017-10-26 18:54 ` Ferruh Yigit
2017-09-11 15:13 ` [dpdk-dev] [PATCH 09/10] app/test-crypto-perf: fix memory leak Olivier Matz
2017-10-05 9:29 ` De Lara Guarch, Pablo
2017-09-11 15:13 ` [dpdk-dev] [PATCH 10/10] app/test-crypto-perf: fix compilation with -Og Olivier Matz
2017-10-05 9:36 ` De Lara Guarch, Pablo
2017-09-11 15:28 ` [dpdk-dev] [PATCH 00/10] " Bruce Richardson
2017-10-06 0:26 ` Ferruh Yigit
2017-10-06 7:31 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=228abb94-4939-8425-9451-2fb57fd1c567@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).