From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
"Akhil Goyal" <gakhil@marvell.com>,
"Aman Singh" <aman.deep.singh@intel.com>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
"Bruce Richardson" <bruce.richardson@intel.com>,
Fengchengwen <fengchengwen@huawei.com>,
"Dariusz Sosnowski" <dsosnowski@nvidia.com>,
"Dmitry Kozlyuk" <dmitry.kozliuk@gmail.com>,
"Fan Zhang" <fanzhang.oss@gmail.com>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Harry van Haaren" <harry.van.haaren@intel.com>,
"Honnappa Nagarahalli" <honnappa.nagarahalli@arm.com>,
"Jiayu Hu" <hujiayu.hu@foxmail.com>,
"Jingjing Wu" <jingjing.wu@intel.com>,
"Kevin Laatz" <kevin.laatz@intel.com>,
"Konstantin Ananyev" <konstantin.v.ananyev@yandex.ru>,
"Matan Azrad" <matan@nvidia.com>, "Ori Kam" <orika@nvidia.com>,
"Pallavi Kadam" <pallavi.kadam@intel.com>,
"Reshma Pattan" <reshma.pattan@intel.com>,
"Sameh Gobriel" <sameh.gobriel@intel.com>,
"Suanming Mou" <suanmingm@nvidia.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Viacheslav Ovsiienko" <viacheslavo@nvidia.com>,
"Vladimir Medvedkin" <vladimir.medvedkin@intel.com>,
"Volodymyr Fialko" <vfialko@marvell.com>,
"Yipeng Wang" <yipeng1.wang@intel.com>,
"Yuying Zhang" <Yuying.Zhang@intel.com>
Subject: RE: [PATCH 00/16] remove use of VLAs for Windows built code
Date: Thu, 18 Apr 2024 12:11:35 +0000 [thread overview]
Message-ID: <228ca3e7cd7f4b5893343527e1727221@huawei.com> (raw)
In-Reply-To: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com>
Hi Tyler,
> As per guidance technical board meeting 2024/04/17. This series
> removes the use of VLAs from code built for Windows for all 3
> toolchains. If there are additional opportunities to convert VLAs
> to regular C arrays please provide the details for incorporation
> into the series.
I submitted the RFC series:
https://patchwork.dpdk.org/project/dpdk/list/?series=31781
that provides alternate approach to VLA removal (without alloca())
for core libs.
Feel free to re-use whatever is appropriate in your series.
If time permits, I'll try to look to other libs from your series
(probably next week or so).
Konstantin
>
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Tyler Retzlaff (16):
> eal: include header required for alloca
> hash: remove use of VLAs for Windows built code
> ethdev: remove use of VLAs for Windows built code
> gro: remove use of VLAs for Windows built code
> latencystats: remove use of VLAs for Windows built code
> lpm: remove use of VLAs for Windows built code
> rcu: remove use of VLAs for Windows built code
> app/testpmd: remove use of VLAs for Windows built code
> test: remove use of VLAs for Windows built code
> common/idpf: remove use of VLAs for Windows built code
> net/i40e: remove use of VLAs for Windows built code
> net/ice: remove use of VLAs for Windows built code
> net/ixgbe: remove use of VLAs for Windows built code
> common/mlx5: remove use of VLAs for Windows built code
> net/mlx5: remove use of VLAs for Windows built code
> build: enable vla warnings on Windows built code
>
> app/test-pmd/cmdline.c | 2 +-
> app/test-pmd/cmdline_flow.c | 9 +++--
> app/test-pmd/config.c | 16 +++++----
> app/test-pmd/shared_rxq_fwd.c | 2 +-
> app/test/test.c | 2 +-
> app/test/test_cmdline_string.c | 2 +-
> app/test/test_cryptodev.c | 32 +++++++++---------
> app/test/test_cryptodev_blockcipher.c | 4 +--
> app/test/test_cryptodev_crosscheck.c | 2 +-
> app/test/test_dmadev.c | 9 +++--
> app/test/test_hash.c | 8 ++---
> app/test/test_mempool.c | 25 +++++++-------
> app/test/test_reassembly_perf.c | 4 +--
> app/test/test_reorder.c | 48 +++++++++++++++------------
> app/test/test_service_cores.c | 9 +++--
> app/test/test_thash.c | 7 ++--
> config/meson.build | 4 +++
> drivers/common/idpf/idpf_common_rxtx.c | 2 +-
> drivers/common/idpf/idpf_common_rxtx_avx512.c | 6 ++--
> drivers/common/mlx5/mlx5_common.h | 4 +--
> drivers/common/mlx5/mlx5_devx_cmds.c | 7 ++--
> drivers/net/i40e/i40e_testpmd.c | 5 ++-
> drivers/net/ice/ice_rxtx.c | 2 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 5 +--
> drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 2 +-
> drivers/net/mlx5/mlx5.c | 5 ++-
> drivers/net/mlx5/mlx5_flow.c | 6 ++--
> lib/eal/linux/include/rte_os.h | 1 +
> lib/eal/windows/include/rte_os.h | 1 +
> lib/ethdev/rte_ethdev.c | 9 ++---
> lib/gro/rte_gro.c | 4 +--
> lib/hash/rte_cuckoo_hash.c | 4 +--
> lib/hash/rte_thash.c | 2 +-
> lib/latencystats/rte_latencystats.c | 2 +-
> lib/lpm/rte_lpm.h | 2 +-
> lib/rcu/rte_rcu_qsbr.c | 6 ++--
> 36 files changed, 137 insertions(+), 123 deletions(-)
>
> --
> 1.8.3.1
next prev parent reply other threads:[~2024-04-18 12:11 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 23:41 Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 01/16] eal: include header required for alloca Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 02/16] hash: remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-18 6:45 ` Morten Brørup
2024-04-17 23:41 ` [PATCH 03/16] ethdev: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 04/16] gro: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 05/16] latencystats: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 06/16] lpm: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 07/16] rcu: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 08/16] app/testpmd: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 09/16] test: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 10/16] common/idpf: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 11/16] net/i40e: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 12/16] net/ice: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 13/16] net/ixgbe: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 14/16] common/mlx5: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 15/16] net/mlx5: " Tyler Retzlaff
2024-04-17 23:41 ` [PATCH 16/16] build: enable vla warnings on " Tyler Retzlaff
2024-04-18 6:48 ` Morten Brørup
2024-04-18 15:12 ` Tyler Retzlaff
2024-04-18 15:23 ` Bruce Richardson
2024-04-18 19:22 ` Morten Brørup
2024-04-18 6:49 ` [PATCH 00/16] remove use of VLAs for " Morten Brørup
2024-04-18 12:11 ` Konstantin Ananyev [this message]
2024-04-18 15:15 ` Tyler Retzlaff
2024-04-18 15:35 ` Konstantin Ananyev
2024-04-18 20:02 ` [PATCH v2 00/19] remove use of VLAs for Windows Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 01/19] eal: include header required for alloca Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 02/19] eal/linux: remove use of VLAs Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 03/19] eal/common: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 04/19] ethdev: remove use of VLAs for Windows built code Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 05/19] hash: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 06/19] hash/thash: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 07/19] rcu: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 08/19] gro: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 09/19] latencystats: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 10/19] lpm: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 11/19] app/testpmd: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 12/19] test: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 13/19] common/idpf: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 14/19] net/i40e: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 15/19] net/ice: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 16/19] net/ixgbe: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 17/19] common/mlx5: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 18/19] net/mlx5: " Tyler Retzlaff
2024-04-18 20:02 ` [PATCH v2 19/19] build: enable vla warnings on " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 00/19] remove use of VLAs for Windows Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 01/19] eal: include header required for alloca Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 02/19] eal/linux: remove use of VLAs Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 03/19] eal/common: " Tyler Retzlaff
2024-05-07 0:42 ` Stephen Hemminger
2024-05-06 18:18 ` [PATCH v3 04/19] ethdev: remove use of VLAs for Windows built code Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 05/19] hash: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 06/19] hash/thash: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 07/19] rcu: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 08/19] gro: " Tyler Retzlaff
2024-05-07 0:47 ` Stephen Hemminger
2024-05-06 18:18 ` [PATCH v3 09/19] latencystats: " Tyler Retzlaff
2024-05-07 0:47 ` Stephen Hemminger
2024-05-06 18:18 ` [PATCH v3 10/19] lpm: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 11/19] app/testpmd: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 12/19] test: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 13/19] common/idpf: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 14/19] net/i40e: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 15/19] net/ice: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 16/19] net/ixgbe: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 17/19] common/mlx5: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 18/19] net/mlx5: " Tyler Retzlaff
2024-05-06 18:18 ` [PATCH v3 19/19] build: enable vla warnings on " Tyler Retzlaff
2024-05-07 2:53 ` [PATCH 1/2] lpm: remove unnecessary temporary VLA Stephen Hemminger
2024-05-07 2:53 ` [PATCH 2/2] latencystats: replace use of VLA Stephen Hemminger
2024-05-07 7:51 ` [PATCH 1/2] lpm: remove unnecessary temporary VLA Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=228ca3e7cd7f4b5893343527e1727221@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=Yuying.Zhang@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dsosnowski@nvidia.com \
--cc=fanzhang.oss@gmail.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=gakhil@marvell.com \
--cc=harry.van.haaren@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=hujiayu.hu@foxmail.com \
--cc=jingjing.wu@intel.com \
--cc=kevin.laatz@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=matan@nvidia.com \
--cc=mb@smartsharesystems.com \
--cc=orika@nvidia.com \
--cc=pallavi.kadam@intel.com \
--cc=reshma.pattan@intel.com \
--cc=roretzla@linux.microsoft.com \
--cc=sameh.gobriel@intel.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=vfialko@marvell.com \
--cc=viacheslavo@nvidia.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).