DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>,
	"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
	"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
	"Zhang, Ke1X" <ke1x.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Matz, Olivier" <olivier.matz@6wind.com>,
	"Zhang, Yuying" <yuying.zhang@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [PATCH v2] net/i40e: support enabling/disabling source pruning
Date: Wed, 01 Feb 2023 12:11:24 +0100	[thread overview]
Message-ID: <2296416.n0HT0TaD9V@thomas> (raw)
In-Reply-To: <PH7PR11MB5984EFDDE2606F234A17F22EDCD09@PH7PR11MB5984.namprd11.prod.outlook.com>

31/01/2023 04:28, Zhang, Ke1X:
> From: David Marchand <david.marchand@redhat.com>
> > On Mon, Jan 30, 2023 at 9:23 AM Ke Zhang <ke1x.zhang@intel.com> wrote:
> > >
> > > VRRP advertisement packets are dropped on i40e PF devices because
> > when
> > > a MAC address is added to a device, packets originating from that MAC
> > > address are dropped.
> > >
> > > This patch adds a PMD specific API to enable/disable source pruning to
> > > fix above issue.
> > >
> > > Bugzilla ID: 648
> > >
> > > Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
> > > ---
> > >  app/test-pmd/cmdline.c          | 84
> > +++++++++++++++++++++++++++++++++
> > >  drivers/net/i40e/i40e_ethdev.c  | 43 +++++++++++++++++
> > > drivers/net/i40e/i40e_ethdev.h  |  1 +
> > > drivers/net/i40e/rte_pmd_i40e.c | 20 ++++++++
> > > drivers/net/i40e/rte_pmd_i40e.h | 16 +++++++
> > >  5 files changed, 164 insertions(+)
> > >
> > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > > cb8c174020..76a574affd 100644
> > > --- a/app/test-pmd/cmdline.c
> > > +++ b/app/test-pmd/cmdline.c
> > > @@ -776,6 +776,9 @@ static void cmd_help_long_parsed(void
> > > *parsed_result,
> > >
> > >                         "port cleanup (port_id) txq (queue_id) (free_cnt)\n"
> > >                         "    Cleanup txq mbufs for a specific Tx queue\n\n"
> > > +
> > > +                       "port config (port_id|all) src_prune (on|off)\n"
> > > +                       "    Set source prune on port_id, or all.\n\n"
> > >                 );
> > >         }
> > >
> > 
> > - This seems i40e specific, please move to drivers/net/i40e/i40e_testpmd.c.
> > 
> > - Besides, I would prefer that something in the command name clearly states
> > this is driver (here, i40e) specific.
> > Like "port config XX i40e_src_prune" or maybe the other way around, start
> > with a "driver i40e" prefix.
> > 
> > Maybe others have an opinion.
> > 
> > 
> > --
> > David Marchand
> 
> Thanks for your comments, this command could be used for other Intel NIC like ice,
> And It is only finished for i40e in this story: https://jira.devtools.intel.com/browse/DPDK-29564

Only Intel has access to this URL.

On the principle, you should not update testpmd commands in a patch for i40e.
We add testpmd commands when adding new features in ethdev.

Here specifically, you are adding rte_pmd_i40e_set_src_prune()
with a vague explanation: "Enable/Disable source prune on all the PF."
Without more information, I cannot judge whether the feature is generic or not.
So for now, this is a nack.



  reply	other threads:[~2023-02-01 11:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19  9:04 [dpdk-dev] [PATCH] net/i40e: disable " Alvin Zhang
2021-10-19  9:38 ` [dpdk-dev] [PATCH v2] " Alvin Zhang
2021-10-20  1:28   ` [dpdk-dev] [PATCH v3] " Alvin Zhang
2022-02-21  8:30     ` Jiang, YuX
2022-02-21  9:35       ` Morten Brørup
2022-12-26  9:03         ` Zhang, Ke1X
2022-12-26 10:26           ` Morten Brørup
2022-12-26 10:27           ` Morten Brørup
2023-01-09  2:20     ` [PATCH] " Ke Zhang
2023-01-09  7:40       ` Morten Brørup
2023-01-13 12:50       ` Ferruh Yigit
2023-01-30  8:09       ` [PATCH v2] net/i40e: support enabling/disabling " Ke Zhang
2023-01-30  8:41         ` Morten Brørup
2023-01-30  8:58         ` David Marchand
2023-01-31  3:28           ` Zhang, Ke1X
2023-02-01 11:11             ` Thomas Monjalon [this message]
2023-02-07  1:40               ` Zhang, Ke1X
2023-02-07  8:35                 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2296416.n0HT0TaD9V@thomas \
    --to=thomas@monjalon.net \
    --cc=beilei.xing@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=ke1x.zhang@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=olivier.matz@6wind.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).