From: Thomas Monjalon <thomas@monjalon.net>
To: Jan Blunck <jblunck@infradead.org>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>,
Declan Doherty <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: remove vdev probe by dev args
Date: Fri, 16 Jun 2017 16:20:03 +0200 [thread overview]
Message-ID: <23043433.nqfcUMGdDr@xps> (raw)
In-Reply-To: <1eae2dda-3fb3-1d46-5d45-1493c1fe1cd4@intel.com>
Please Jan, could you comment?
09/06/2017 11:21, Ferruh Yigit:
> On 6/8/2017 9:45 PM, Thomas Monjalon wrote:
> > 10/05/2017 13:01, Ferruh Yigit:
> >> Virtual device/driver probing done via name.
> >>
> >> A new alternative method introduced to probe the device with providing
> >> driver name in devargs as "driver=<driver_name>".
> >>
> >> This patch removes alternative method and fixes virtual device usages
> >> with proper device names.
> >>
> >> Fixes: 87c3bf29c642 ("test: do not short-circuit null device creation")
> >> Fixes: d39670086a63 ("eal: parse driver argument before probing drivers")
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >> ---
> > [...]
> >> static int
> >> vdev_probe_all_drivers(struct rte_vdev_device *dev)
> >> {
> >> const char *name;
> >> - char *drv_name;
> >> struct rte_vdev_driver *driver;
> >> int ret = 1;
> >>
> >> - drv_name = parse_driver_arg(rte_vdev_device_args(dev));
> >> - name = drv_name ? drv_name : rte_vdev_device_name(dev);
> >> + name = rte_vdev_device_name(dev);
> >
> > It seems you are reverting the commit d39670086a63:
> > eal: parse driver argument before probing drivers
>
> Mostly yes.
>
> >
> > In some cases the virtual device name should be totally different than
> > the driver being used for the device. Therefore lets parse the devargs for
> > the "driver" argument before probing drivers in vdev_probe_all_drivers().
> >
> > Is this "driver" option useless?
>
> There is already a generic way to probe, why need another method, I
> didn't get the motivation but this looks like a hack, only place I found
> used is in bonding unit test, which can be switched to generic way
> without this support.
>
> And this is a hidden / an undocumented feature.
>
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2017-06-16 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 11:01 Ferruh Yigit
2017-06-08 20:45 ` Thomas Monjalon
2017-06-09 9:21 ` Ferruh Yigit
2017-06-16 14:20 ` Thomas Monjalon [this message]
2017-07-09 7:54 ` Jan Blunck
2017-07-09 22:02 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23043433.nqfcUMGdDr@xps \
--to=thomas@monjalon.net \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=jblunck@infradead.org \
--cc=mtetsuyah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).