From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
jerinj@marvell.com, Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix build with ICC
Date: Thu, 27 Jun 2019 08:57:03 +0100 [thread overview]
Message-ID: <23163c6a-3f38-fd17-a5a7-1874b76d995c@intel.com> (raw)
In-Reply-To: <20190626230742.26195-1-stephen@networkplumber.org>
On 6/27/2019 12:07 AM, Stephen Hemminger wrote:
> The Intel compiler is pickier about casts and generates:
> otx2_mempool_ops.c(344): error #191: type qualifier is meaningless on cast type
> int64_t * const addr = (int64_t * const)
> ^
> This is because of the nature of const.
> In this example, the expression is being cast into a pointer
> that can not be modified. This is meanlingless because the
> expression is already a lvalue.
>
> See https://en.wikipedia.org/wiki/Const_(computer_programming)
>
> Fixes: d7a0da3c0043 ("mempool/octeontx2: add fast path mempool ops")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks.
prev parent reply other threads:[~2019-06-27 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 23:07 Stephen Hemminger
2019-06-27 7:57 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23163c6a-3f38-fd17-a5a7-1874b76d995c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).