From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>,
Vipin Varghese <vipin.varghese@intel.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v1] mk: allow use of toolchain cflags
Date: Mon, 06 Nov 2017 22:07:30 +0100 [thread overview]
Message-ID: <2369574.SFH6e9u1pT@xps> (raw)
In-Reply-To: <1509702003-70630-1-git-send-email-david.hunt@intel.com>
03/11/2017 10:40, David Hunt:
> From: Vipin Varghese <vipin.varghese@intel.com>
>
> with 'export TOOLCHAIN_CFLAGS' the values are
> not inherited throuhout make system. The change
> appends the user defined cflags.
Why do you want to use export from the shell environment?
The standard way of overriding a variable with make,
is to specify a value on the make command line.
[...]
> -TOOLCHAIN_ASFLAGS =
> -TOOLCHAIN_CFLAGS =
> -TOOLCHAIN_LDFLAGS =
> +TOOLCHAIN_ASFLAGS +=
> +TOOLCHAIN_CFLAGS +=
> +TOOLCHAIN_LDFLAGS +=
There is nothing to append here.
It is here only for documentation purpose.
If you really want to take environment value into account,
you can just comment this assignment or use ?= operator.
Note that you can also use EXTRA_CFLAGS.
I would be in favor of removing these variables.
We have too many variables.
next prev parent reply other threads:[~2017-11-06 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 9:40 David Hunt
2017-11-06 21:07 ` Thomas Monjalon [this message]
2017-11-07 0:15 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2369574.SFH6e9u1pT@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=vipin.varghese@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).