From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes
Date: Sun, 16 Jul 2017 16:55:33 +0300 [thread overview]
Message-ID: <2387f800-5084-e0e1-5cc7-4cfeaa679d8a@solarflare.com> (raw)
In-Reply-To: <20170714183027.16021-1-stephen@networkplumber.org>
On 07/14/2017 09:30 PM, Stephen Hemminger wrote:
> While writing new driver, I noticed a lot of unnecessary duplication of
> code in drivers for handling the eth_dev link status information. While
> consolidating this, it also became obvious that several drivers have
> bugs in this are because they don't return the correct value.
> Also, some drivers were not fully initializing all the space (including
> padding).
>
> This is compile test only at this point, I don't have any of the hardware
> available (except virtio) to test.
>
> Stephen Hemminger (14):
> ethdev: add link status read/write functions
> virtio: use eth_link_read/write (and bug fix)
> bnxt: use rte_link_update
> vmxnet3: use rte_eth_link_update
> dpaa2: use rte_eth_link_update
> nfp: use rte_eth_link_update
> e1000: use rte_eth_link_update
> ixgbe: use rte_eth_link_update
> sfc: use new rte_eth_link helpers
> i40e: use rte_eth_link_update (and bug fix)
> liquidio: use _rte_eth_link_update
> thunderx: use _rte_eth_link_update
> szedata: use _rte_eth_link_update
> enic: use _rte_eth_link_update
>
> drivers/net/bnxt/bnxt_ethdev.c | 21 +-------
> drivers/net/dpaa2/dpaa2_ethdev.c | 66 +++---------------------
> drivers/net/e1000/em_ethdev.c | 70 ++------------------------
> drivers/net/e1000/igb_ethdev.c | 71 ++------------------------
> drivers/net/enic/enic_ethdev.c | 5 +-
> drivers/net/enic/enic_main.c | 16 +++---
> drivers/net/i40e/i40e_ethdev.c | 44 +++-------------
> drivers/net/i40e/i40e_ethdev_vf.c | 19 +------
> drivers/net/ixgbe/ixgbe_ethdev.c | 89 +++++----------------------------
> drivers/net/liquidio/lio_ethdev.c | 76 +++++++---------------------
> drivers/net/nfp/nfp_net.c | 74 +++------------------------
> drivers/net/sfc/sfc_ethdev.c | 27 +++-------
> drivers/net/sfc/sfc_ev.c | 23 ++-------
> drivers/net/szedata2/rte_eth_szedata2.c | 18 +++----
> drivers/net/thunderx/nicvf_ethdev.c | 17 +------
> drivers/net/virtio/virtio_ethdev.c | 54 +++-----------------
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 66 ++----------------------
> lib/librte_ether/rte_ethdev.c | 36 +++++++++++++
> lib/librte_ether/rte_ethdev.h | 28 +++++++++++
> 19 files changed, 171 insertions(+), 649 deletions(-)
>
I've provided my comments to individual patches.
In general it is very good that it removes so much duplicated and
nontrivial code with atomtics. It raises many questions and I think
finally it will allow to clarify link status API for PMD maintainers and
users.
Andrew.
next prev parent reply other threads:[~2017-07-16 13:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 18:30 Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 01/14] ethdev: add link status read/write functions Stephen Hemminger
2017-07-16 13:26 ` Andrew Rybchenko
2017-07-17 15:58 ` Stephen Hemminger
2017-07-17 16:12 ` Andrew Rybchenko
2017-07-17 16:21 ` Stephen Hemminger
2017-07-17 16:31 ` Andrew Rybchenko
2017-10-11 8:32 ` Yang, Qiming
2017-10-13 15:12 ` Stephen Hemminger
2018-01-05 14:24 ` Thomas Monjalon
2018-01-05 20:15 ` Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 02/14] virtio: use eth_link_read/write (and bug fix) Stephen Hemminger
2017-07-16 12:33 ` Andrew Rybchenko
2017-07-17 16:01 ` Stephen Hemminger
2017-07-17 16:14 ` [dpdk-dev] ***Spam*** " Andrew Rybchenko
2017-07-17 16:28 ` [dpdk-dev] " Stephen Hemminger
2018-01-05 15:04 ` Thomas Monjalon
2017-07-14 18:30 ` [dpdk-dev] [RFC 03/14] bnxt: use rte_link_update Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 04/14] vmxnet3: use rte_eth_link_update Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 05/14] dpaa2: " Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 06/14] nfp: " Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 07/14] e1000: " Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 08/14] ixgbe: " Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 09/14] sfc: use new rte_eth_link helpers Stephen Hemminger
2017-07-16 13:48 ` Andrew Rybchenko
2017-07-17 16:02 ` Stephen Hemminger
2017-07-17 16:19 ` Andrew Rybchenko
2017-07-14 18:30 ` [dpdk-dev] [RFC 10/14] i40e: use rte_eth_link_update (and bug fix) Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 11/14] liquidio: use _rte_eth_link_update Stephen Hemminger
2017-07-18 10:17 ` Shijith Thotton
2017-07-14 18:30 ` [dpdk-dev] [RFC 12/14] thunderx: " Stephen Hemminger
2017-07-14 18:30 ` [dpdk-dev] [RFC 13/14] szedata: " Stephen Hemminger
2017-07-16 12:46 ` Andrew Rybchenko
2017-07-14 18:30 ` [dpdk-dev] [RFC 14/14] enic: " Stephen Hemminger
2017-07-16 13:55 ` Andrew Rybchenko [this message]
2018-01-05 14:29 ` [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes Thomas Monjalon
2018-01-05 20:18 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2387f800-5084-e0e1-5cc7-4cfeaa679d8a@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).