From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
"Wiles, Keith" <keith.wiles@intel.com>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name
Date: Tue, 03 Apr 2018 18:43:15 +0200 [thread overview]
Message-ID: <24175442.FuofMSqENj@xps> (raw)
In-Reply-To: <da96f7c7-8f10-ad4d-71a4-224205ebd25d@intel.com>
03/04/2018 15:29, Ferruh Yigit:
> On 4/3/2018 2:17 PM, Wiles, Keith wrote:
> >> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> Library folder name and output library name are same except a few flaws
> >> including librte_ether.
> >>
> >> This library is network device abstraction layer, the name "ethdev" fits
> >> better than "ether", and library & header files already named as ethdev.
> >>
> >> Also there is a rte_ether.h in the net library which can cause confusion.
> >>
> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >> ---
> >> Not sure if the we are ready for this change J
> >>
> >> This is one the issues that the hassle of the change doesn't worth the
> >> benefit and you may prefer to live with the flaw.
> >>
> >> Also a concern is this breaks the git history.
> >
> > I believe as long as you used ‘git mv’ the git history should not be broken, correct?
I think "git mv" does nothing special. Git tracks the content, so it is the
same as using "mv + git add + git rm".
> I think this will help in some conflict resolving or git blame, but if you check
> the history directly with path, it won't show the past:
>
> "git log --oneline lib/librte_ethdev/": Will start from this commit
You can use --follow.
Unfortunately, it does not work well with gitk.
You need to use a trick like https://stackoverflow.com/a/37375502
But there is no good solution when tracking a directory, like ethdev,
which had a file split recently, and a directory rename.
next prev parent reply other threads:[~2018-04-03 16:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 9:28 Ferruh Yigit
2018-04-03 9:58 ` Bruce Richardson
2018-04-03 10:24 ` Thomas Monjalon
2018-04-03 10:57 ` Bruce Richardson
2018-04-03 12:20 ` Thomas Monjalon
2018-04-03 12:33 ` Bruce Richardson
2018-04-03 13:23 ` Wiles, Keith
2018-04-03 13:17 ` Wiles, Keith
2018-04-03 13:29 ` Ferruh Yigit
2018-04-03 16:43 ` Thomas Monjalon [this message]
2018-04-04 0:50 ` Jerin Jacob
2018-04-26 21:25 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-04-27 0:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24175442.FuofMSqENj@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).