DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Qian Xu <qian.q.xu@intel.com>, Masaru OKI <m-oki@stratosphere.co.jp>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: Re: [dpdk-dev] [PATCH] igb_uio: fix vmware e1000 input/output error
Date: Mon, 21 Mar 2016 11:07:56 +0100	[thread overview]
Message-ID: <2437286.FLD0q4sve1@xps13> (raw)
In-Reply-To: <1458550874-15709-1-git-send-email-qian.q.xu@intel.com>

2016-03-21 17:01, Qian Xu:
> INTX is badly emulated in Vmware, INTX toggle check didn't work
> with Vmware e1000 device. The patch is to fix the issue.

Is it possible to detect a VMware e1000 device?

> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>  	case RTE_INTR_MODE_LEGACY:
> -		if (pci_intx_mask_supported(dev)) {
> -			dev_dbg(&dev->dev, "using INTX");
> -			udev->info.irq_flags = IRQF_SHARED;
> -			udev->info.irq = dev->irq;
> -			udev->mode = RTE_INTR_MODE_LEGACY;
> -			break;
> -		}
> -		dev_notice(&dev->dev, "PCI INTX mask not supported\n");
> +                dev_dbg(&dev->dev, "using INTX");
> +                udev->info.irq_flags = IRQF_SHARED;
> +                udev->info.irq = dev->irq;
> +                udev->mode = RTE_INTR_MODE_LEGACY;
> +                break;
>  		/* fall back to no IRQ */
>  	case RTE_INTR_MODE_NONE:

This patch is removing the INTX support detection and the
fallback to no IRQ.

  reply	other threads:[~2016-03-21 10:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21  9:01 Qian Xu
2016-03-21 10:07 ` Thomas Monjalon [this message]
2016-03-23  1:23   ` Xu, Qian Q
2016-03-23  2:05   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2437286.FLD0q4sve1@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=m-oki@stratosphere.co.jp \
    --cc=qian.q.xu@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).