From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Yang, Ziye" <ziye.yang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: Add the class_id support in pci probe
Date: Thu, 19 May 2016 14:57:17 +0200 [thread overview]
Message-ID: <243965117.o52RgkbZZP@xps13> (raw)
In-Reply-To: <FA6C2217B01E9D48A581BB486602101401758FC6@shsmsx102.ccr.corp.intel.com>
2016-05-19 12:18, Yang, Ziye:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> 2016-05-11 14:08, Ziye Yang:
> > + dev->id.class_id = (uint32_t)tmp && CLASS_ANY_ID;
>
> Should be a bitwise &. Why masking is needed?
> [Ziye] Only 24bit info is needed.
What are the other bits?
Please put a comment in the code.
next prev parent reply other threads:[~2016-05-19 12:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 6:08 Ziye Yang
2016-05-11 15:21 ` Stephen Hemminger
2016-05-11 15:34 ` Richardson, Bruce
2016-05-19 10:33 ` Thomas Monjalon
2016-05-19 12:18 ` Yang, Ziye
2016-05-19 12:57 ` Thomas Monjalon [this message]
2016-05-19 13:14 ` Yang, Ziye
2016-05-19 12:25 ` [dpdk-dev] [PATCH v2] ci: " Ziye Yang
2016-05-19 13:17 ` [dpdk-dev] [PATCH v3] " Ziye Yang
2016-05-24 9:29 ` Thomas Monjalon
2016-05-24 12:50 ` [dpdk-dev] [PATCH v4] Pci: Add the class_id support Ziye Yang
2016-06-14 14:52 ` Thomas Monjalon
2016-07-06 11:08 ` Ferruh Yigit
2016-07-07 7:46 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2015-12-29 2:53 [dpdk-dev] [PATCH] pci: Add the class_id support in pci probe Ziye Yang
2015-12-31 17:12 ` Stephen Hemminger
2016-01-13 11:55 ` Bruce Richardson
2016-01-13 12:22 ` Panu Matilainen
2016-01-28 21:38 ` Thomas Monjalon
2016-01-29 9:21 ` Panu Matilainen
2016-01-29 9:34 ` Thomas Monjalon
2016-01-29 10:10 ` Panu Matilainen
2016-01-29 12:47 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=243965117.o52RgkbZZP@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ziye.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).