From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule
Date: Thu, 16 Feb 2017 11:44:33 +0100 [thread overview]
Message-ID: <2458783.cUhEIUrdmi@xps13> (raw)
In-Reply-To: <e96fc4e1-6a93-2d52-d3bd-87c02609af93@intel.com>
2017-02-16 10:21, Ferruh Yigit:
> On 2/16/2017 9:26 AM, Thomas Monjalon wrote:
> > 2017-02-15 15:26, Ferruh Yigit:
> >> --- a/mk/rte.sdkroot.mk
> >> +++ b/mk/rte.sdkroot.mk
> >> @@ -92,8 +92,8 @@ default: all
> >> config showconfigs showversion showversionum:
> >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@
> >>
> >> -.PHONY: test fast_test ring_test mempool_test perf_test coverage
> >> -test fast_test ring_test mempool_test perf_test coverage:
> >> +.PHONY: test test-run fast_test ring_test mempool_test perf_test coverage
> >> +test test-run fast_test ring_test mempool_test perf_test coverage:
> >> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@
> >
> > "test" is a shortcut for build + basic tests.
> > I think test-run can be better named. It runs all the basic tests registered
> > in autotests. "test-all" would be wrong. What about "test-basic"?
>
> Right, "test-basic" matches more to existing rules (test-fast,
> test-perf, ..), all has hidden "run" action implied, I will use
> "test-basic" if there is no objection.
>
> My concerns is "test-basic" "running basic tests without compilation"
> may not be obvious for a newcomer.
> Should I add a line to "make help" for "test" and "test-*" rules?
>
> Like:
> test Compile tests and run basic unit tests
> test-* Run specific subset of the unit tests
Yes it looks good.
next prev parent reply other threads:[~2017-02-16 10:44 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 15:13 [dpdk-dev] [RFC 17.05] test: move tests to separate folder Ferruh Yigit
2017-02-14 15:41 ` Bruce Richardson
2017-02-14 15:51 ` Wiles, Keith
2017-02-14 16:12 ` Mcnamara, John
2017-02-15 9:03 ` Thomas Monjalon
2017-02-14 17:07 ` Ferruh Yigit
2017-02-14 17:30 ` Richardson, Bruce
2017-02-15 2:11 ` Yuanhan Liu
2017-02-15 10:06 ` Ferruh Yigit
2017-02-15 11:16 ` Thomas Monjalon
2017-02-15 11:28 ` Ferruh Yigit
2017-02-14 16:15 ` Mcnamara, John
2017-02-15 15:26 ` [dpdk-dev] [PATCH 1/4] " Ferruh Yigit
2017-02-15 15:26 ` [dpdk-dev] [PATCH 2/4] mk: do not build tests by default Ferruh Yigit
2017-02-15 16:58 ` Thomas Monjalon
2017-02-15 17:30 ` Ferruh Yigit
2017-02-16 8:53 ` Thomas Monjalon
2017-02-16 10:07 ` Ferruh Yigit
2017-02-15 15:26 ` [dpdk-dev] [PATCH 3/4] mk: add new test-run make rule Ferruh Yigit
2017-02-15 17:07 ` Bruce Richardson
2017-02-15 17:41 ` Ferruh Yigit
2017-02-16 9:08 ` Bruce Richardson
2017-02-16 9:26 ` Thomas Monjalon
2017-02-16 10:21 ` Ferruh Yigit
2017-02-16 10:44 ` Thomas Monjalon [this message]
2017-02-15 15:26 ` [dpdk-dev] [PATCH 4/4] mk: rename test related make rules Ferruh Yigit
2017-02-16 9:10 ` [dpdk-dev] [PATCH 1/4] test: move tests to separate folder Bruce Richardson
2017-02-16 14:57 ` [dpdk-dev] [PATCH v2 1/5] " Ferruh Yigit
2017-02-16 14:57 ` [dpdk-dev] [PATCH v2 2/5] mk: do not build tests by default Ferruh Yigit
2017-02-16 14:57 ` [dpdk-dev] [PATCH v2 3/5] mk: add new test-basic make rule Ferruh Yigit
2017-02-16 14:57 ` [dpdk-dev] [PATCH v2 4/5] mk: rename test related make rules Ferruh Yigit
2017-02-16 14:57 ` [dpdk-dev] [PATCH v2 5/5] doc: document test related make rules in make help Ferruh Yigit
2017-02-20 15:23 ` Mcnamara, John
2017-02-28 15:19 ` [dpdk-dev] [PATCH v2 1/5] test: move tests to separate folder Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2458783.cUhEIUrdmi@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).