DPDK patches and discussions
 help / color / mirror / Atom feed

From: Yongseok Koh <yskoh@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>
Cc: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>,
	"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix probe return value polarity
Date: Wed, 2 May 2018 01:54:37 +0000	[thread overview]
Message-ID: <246A35AF-2BFD-41C6-BEFC-A93D559FBA88@mellanox.com> (raw)
In-Reply-To: <20180501111806.112319-2-shahafs@mellanox.com>


> On May 1, 2018, at 4:18 AM, Shahaf Shuler <shahafs@mellanox.com> wrote:
> 
> mlx5 prefixed function returns a negative errno value.
> the error handler on mlx5_pci_probe is doing the same.
> 
> Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
> Cc: nelio.laranjeiro@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
> index 46cb370a29..ab860b5985 100644
> --- a/drivers/net/mlx5/mlx5.c
> +++ b/drivers/net/mlx5/mlx5.c
> @@ -804,12 +804,16 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
> 				goto error;

Shouldn't you do the same for mlx5_uar_init_secondary()?
Looks like a few more. E.g. mlx5_args(), mlx5_get_mtu() and mlx5_uar_init_primary().
What about ibv_query_port() and mlx5_flow_create_drop_queue()? 

Thanks

> 			/* Receive command fd from primary process */
> 			err = mlx5_socket_connect(eth_dev);
> -			if (err < 0)
> +			if (err < 0) {
> +				err = -err;

Instead of changing sign, how about 'err = rte_errno;' ?
However, err looks redundant to me because mlx5_* funcs set rte_errno.
Here, err is used to set rte_errno at the end.

Thanks,
Yongseok

> 				goto error;
> +			}
> 			/* Remap UAR for Tx queues. */
> 			err = mlx5_tx_uar_remap(eth_dev, err);
> -			if (err)
> +			if (err) {
> +				err = -err;
> 				goto error;
> +			}
> 			/*
> 			 * Ethdev pointer is still required as input since
> 			 * the primary device is not accessible from the
> -- 
> 2.12.0
> 

next prev parent reply	other threads:[~2018-05-02  1:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 11:18 [dpdk-dev] [PATCH 1/2] net/mlx5: fix socket connection return value Shahaf Shuler
2018-05-01 11:18 ` [dpdk-dev] [PATCH 2/2] net/mlx5: fix probe return value polarity Shahaf Shuler
2018-05-02  1:54   ` Yongseok Koh [this message]
2018-05-02  6:49     ` Nélio Laranjeiro
2018-05-03  7:40       ` Shahaf Shuler
2018-05-02  6:50 ` [dpdk-dev] [PATCH 1/2] net/mlx5: fix socket connection return value Nélio Laranjeiro
2018-05-03  7:59 ` [dpdk-dev] [PATCH v2 " Shahaf Shuler
2018-05-03 10:33   ` Shahaf Shuler
2018-05-03  7:59 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix probe return value polarity Shahaf Shuler
2018-05-03  9:53   ` Nélio Laranjeiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=246A35AF-2BFD-41C6-BEFC-A93D559FBA88@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    --cc=nelio.laranjeiro@6wind.com \
    --cc=shahafs@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).