From: Akhil Goyal <akhil.goyal@nxp.com>
To: <alok.makhariya@nxp.com>, <dev@dpdk.org>
Cc: <pablo.de.lara.guarch@intel.com>, <hemant.agrawal@nxp.com>,
<stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] crypto/dpaa2_sec: remove memset of icv on decryption side
Date: Fri, 13 Oct 2017 19:54:27 +0530 [thread overview]
Message-ID: <2470350a-6ec3-6ce6-7100-18c93e49586c@nxp.com> (raw)
In-Reply-To: <20171012130726.4332-4-alok.makhariya@nxp.com>
On 10/12/2017 6:37 PM, alok.makhariya@nxp.com wrote:
> From: Alok Makhariya <alok.makhariya@nxp.com>
>
> Since the packet lengths are modified. It is not required to
> explicitly reset the icv.
>
> Fixes: 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR")
> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alok Makhariya <alok.makhariya@nxp.com>
> ---
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> index 9895300..62b9203 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
> @@ -203,7 +203,6 @@ build_authenc_gcm_fd(dpaa2_sec_session *sess,
> old_icv = (uint8_t *)(sge + 1);
> memcpy(old_icv, sym_op->aead.digest.data,
> sess->digest_length);
> - memset(sym_op->aead.digest.data, 0, sess->digest_length);
> DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv));
> sge->length = sess->digest_length;
> DPAA2_SET_FD_LEN(fd, (sym_op->aead.data.length +
> @@ -342,7 +341,6 @@ build_authenc_fd(dpaa2_sec_session *sess,
> old_icv = (uint8_t *)(sge + 1);
> memcpy(old_icv, sym_op->auth.digest.data,
> sess->digest_length);
> - memset(sym_op->auth.digest.data, 0, sess->digest_length);
> DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_icv));
> sge->length = sess->digest_length;
> DPAA2_SET_FD_LEN(fd, (sym_op->auth.data.length +
> @@ -436,7 +434,6 @@ build_auth_fd(dpaa2_sec_session *sess, struct rte_crypto_op *op,
> old_digest = (uint8_t *)(sge + 1);
> rte_memcpy(old_digest, sym_op->auth.digest.data,
> sess->digest_length);
> - memset(sym_op->auth.digest.data, 0, sess->digest_length);
> DPAA2_SET_FLE_ADDR(sge, DPAA2_VADDR_TO_IOVA(old_digest));
> sge->length = sess->digest_length;
> fle->length = sym_op->auth.data.length +
>
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
next prev parent reply other threads:[~2017-10-13 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171012130726.4332-1-alok.makhariya@nxp.com>
2017-10-12 13:07 ` [dpdk-stable] [PATCH] crypto/dpaa2_sec: add check for segmented buffer alok.makhariya
2017-10-13 15:38 ` [dpdk-stable] [PATCH v2] " alok.makhariya
2017-10-13 15:44 ` Akhil Goyal
2017-10-16 14:06 ` De Lara Guarch, Pablo
2017-10-12 13:07 ` [dpdk-stable] [PATCH] crypto/dpaa2_sec: remove memset of icv on decryption side alok.makhariya
2017-10-13 14:24 ` Akhil Goyal [this message]
2017-10-16 11:21 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2470350a-6ec3-6ce6-7100-18c93e49586c@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=alok.makhariya@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).