patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] test: fix hang on FreeBSD
Date: Mon, 21 May 2018 15:16:45 +0200	[thread overview]
Message-ID: <2472085.2sczoQJf8F@xps> (raw)
In-Reply-To: <8ed23c52-4b88-b40a-ccc5-31c6993654a1@intel.com>

21/05/2018 14:58, Radu Nicolau:
> 
> On 5/21/2018 1:30 PM, Thomas Monjalon wrote:
> > 21/05/2018 13:35, Radu Nicolau:
> >> Fixes: af75078fece3 ("first public release")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> >> ---
> >> @@ -34,7 +34,8 @@ test_panic(void)
> >>   		printf("Fork Failed\n");
> >>   		return -1;
> >>   	}
> >> -	wait(&status);
> >> +	sleep(1);
> >> +	waitpid(pid, &status, WNOHANG);
> > Please give an explanation why you are adding this sleep.
> >
> To give a chance to the child process to complete before calling waitpid.

One second in an unit test is a lot.

When I was asking for explanation, I mean usual explanations in commit message:
	- what is the issue
	- what is the root cause
	- what is the reasoning behind the fix

  reply	other threads:[~2018-05-21 13:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-21 11:35 Radu Nicolau
2018-05-21 12:30 ` Thomas Monjalon
2018-05-21 12:58   ` Radu Nicolau
2018-05-21 13:16     ` Thomas Monjalon [this message]
2018-05-21 16:13     ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2018-05-21 13:28 ` Burakov, Anatoly
2018-05-21 13:33   ` Radu Nicolau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2472085.2sczoQJf8F@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).