From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>, john.mcnamara@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix byte order inconsistence between fdir flow and mask
Date: Wed, 27 Jan 2016 10:19:36 +0100 [thread overview]
Message-ID: <2497810.HTMk7hhgUj@xps13> (raw)
In-Reply-To: <1453883856-31246-1-git-send-email-jingjing.wu@intel.com>
2016-01-27 16:37, Jingjing Wu:
> Fixed issue of byte order in ethdev library that the structure
> for setting fdir's mask and flow entry is inconsist and made
> inputs of mask be in big endian.
Please be more precise. Which one is big endian?
Wasn't it tested before?
> fixes: 76c6f89e80d4 ("ixgbe: support new flow director masks")
> 2d4c1a9ea2ac ("ethdev: add new flow director masks")
Please put Fixes: on the two lines.
> --- a/doc/guides/rel_notes/release_2_3.rst
> +++ b/doc/guides/rel_notes/release_2_3.rst
> @@ -19,6 +19,10 @@ Drivers
> Libraries
> ~~~~~~~~~
>
> +* ** fix byte order inconsistence between fdir flow and mask **
> +
> + Fixed issue in ethdev library that the structure for setting
> + fdir's mask and flow entry is inconsist in byte order.
John, comment on release notes formatting?
It's important to have the first items well formatted.
> @@ -39,6 +43,8 @@ API Changes
> ABI Changes
> -----------
>
> +* The fields in The ethdev structures ``rte_eth_fdir_masks`` were
> + changed to be in big endian.
Please take care of uppercase typo here.
> - /* write all the same so that UDP, TCP and SCTP use the same mask */
> + /* write all the same so that UDP, TCP and SCTP use the same mask
> + * (little-endian)
> + */
Spacing typo here.
Sorry for the nits ;)
> - uint8_t mac_addr_byte_mask; /** Per byte MAC address mask */
> + uint8_t mac_addr_byte_mask; /** Bit mask for associated byte */
> uint32_t tunnel_id_mask; /** tunnel ID mask */
> - uint8_t tunnel_type_mask;
> + uint8_t tunnel_type_mask; /**< 1 - Match tunnel type,
> + 0 - Ignore tunnel type. */
These changes seem unrelated with the patch.
It's good to improve doc of this API but it's maybe not enough.
Example:
uint8_t mac_addr_byte_mask; /** Bit mask for associated byte */
Are we sure everybody understand how to fill it?
next prev parent reply other threads:[~2016-01-27 9:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 8:37 Jingjing Wu
2016-01-27 9:19 ` Thomas Monjalon [this message]
2016-01-28 5:55 ` Wu, Jingjing
2016-02-01 2:48 ` [dpdk-dev] [PATCH v2] " Jingjing Wu
2016-03-02 0:25 ` Zhe Tao
2016-03-02 5:18 ` Lu, Wenzhuo
2016-03-04 15:52 ` Thomas Monjalon
2016-03-08 23:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2497810.HTMk7hhgUj@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).