From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
Pavel Belous <Pavel.Belous@aquantia.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/7] net/atlantic: enable macsec configuration
Date: Wed, 17 Apr 2019 18:14:08 +0100 [thread overview]
Message-ID: <24ad567c-facd-c74e-c770-ccc7334b48c9@intel.com> (raw)
In-Reply-To: <75675c055efff4b0ea26bf32049cabd98c252c8f.1555515863.git.igor.russkikh@aquantia.com>
On 4/17/2019 4:45 PM, Igor Russkikh wrote:
> From: Pavel Belous <pavel.belous@aquantia.com>
>
> This is a driver side of macsec configuration routines.
> It fills in config structures and sends requests to FW
> for configuration activities.
>
> We declare macsec offload bits in DPDK offload capabilities.
>
> Also update documentation with feature matrix for the
> enabled feature.
>
> Signed-off-by: Pavel Belous <pavel.belous@aquantia.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
<...>
> @@ -698,6 +700,205 @@ atl_dev_reset(struct rte_eth_dev *dev)
> return ret;
> }
>
> +static int
> +atl_dev_configure_macsec(struct rte_eth_dev *dev)
The build is broken in this patch [1] because static function defined but not
used, indeed this is similar for other functions but they don't cause a build
error since they are not static.
It can be good to add the APIs using these functions and functions in same patch.
[1]
.../dpdk/drivers/net/atlantic/atl_ethdev.c:704:1: error:
‘atl_dev_configure_macsec’ defined but not used [-Werror=unused-function]
atl_dev_configure_macsec(struct rte_eth_dev *dev)
^~~~~~~~~~~~~~~~~~~~~~~~
next prev parent reply other threads:[~2019-04-17 17:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 15:45 [dpdk-dev] [PATCH v2 0/7] add MACSEC hw offload to atlantic PMD Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 1/7] net/atlantic: macsec hardware structures declaration Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 2/7] net/atlantic: enable macsec configuration Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 17:14 ` Ferruh Yigit [this message]
2019-04-17 17:14 ` Ferruh Yigit
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 3/7] net/atlantic: macsec firmware interface Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 4/7] net/atlantic: interrupt handling of macsec events Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 5/7] net/atlantic: implement macsec statistics Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 6/7] net/atlantic: bump internal driver version Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
2019-04-17 15:45 ` [dpdk-dev] [PATCH v2 7/7] net/atlantic: public experimental macsec API Igor Russkikh
2019-04-17 15:45 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24ad567c-facd-c74e-c770-ccc7334b48c9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).