From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
Cc: dev@dpdk.org, ciara.loftus@intel.com, qi.z.zhang@intel.com,
john.mcnamara@intel.com
Subject: Re: [PATCH v4] net/af_xdp: fix missing UMEM feature
Date: Mon, 2 Oct 2023 14:15:51 +0100 [thread overview]
Message-ID: <24c4c344-1c71-4d13-9fc7-8f4eb7601f44@amd.com> (raw)
In-Reply-To: <ZRq/L5dgpHUNDzIF@bricha3-MOBL.ger.corp.intel.com>
On 10/2/2023 2:01 PM, Bruce Richardson wrote:
> On Mon, Oct 02, 2023 at 12:48:52PM +0000, Shibin Koikkara Reeny wrote:
>> Shared UMEM feature is missing in the af_xdp driver build
>> after the commit 33d66940e9ba ("build: use C11 standard").
>>
>> Runtime Error log while using Shared UMEM feature:
>> rte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0
>> init_internals(): Shared UMEM feature not available. Check kernel
>> and libbpf version
>> rte_pmd_af_xdp_probe(): Failed to init internals
>> vdev_probe(): failed to initialize net_af_xdp0 device
>> EAL: Bus (vdev) probe failed.
>>
>> Reason for the missing UMEM feature is because the C11 standard
>> doesn't include the GNU compiler extensions typeof and asm, used
>> by the libbpf and libxdp header files.
>>
>> Meson error log:
>> In file included from
>> dpdk/build/meson-private/tmpf74nkhqd/testfile.c:5:
>> /usr/local/include/bpf/xsk.h: In function 'xsk_prod_nb_free':
>> /usr/local/include/bpf/xsk.h:165:26: error: expected ';' before '___p1'
>> 165 | r->cached_cons = libbpf_smp_load_acquire(r->consumer);
>> | ^~~~~~~~~~~~~~~~~~~~~~~
>> /usr/local/include/bpf/xsk.h:165:26: error: 'asm' undeclared (first use
>> in this function)
>> ...
>> /usr/local/include/bpf/xsk.h:199:9: error: unknown type name 'typeof'
>> 199 | libbpf_smp_store_release(prod->producer, *prod->producer
>> + nb);
>> | ^~~~~~~~~~~~~~~~~~~~~~~~
>>
>> Fix is to provide alternative keywords by using macros [1].
>>
>> Fixes: 33d66940e9ba ("build: use C11 standard")
>>
>> [1] https://gcc.gnu.org/onlinedocs/gcc/C-Dialect-Options.html
>>
>> v4: Updated the commit message.
>> v3: Used alternative keywords fix.
>> v2: Added original commit causing the issue.
>>
>> Signed-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>
>
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
>
I already merged the v3, and updated the commit log while merging,
can you please check the next-net [1] if the commit log is good as it is?
[1]
https://git.dpdk.org/next/dpdk-next-net/commit/?id=a499de2602df505e0313ae468817863b29f2311e
next prev parent reply other threads:[~2023-10-02 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 10:29 [PATCH] net/af_xdp: pass cflags to appropriate build components Shibin Koikkara Reeny
2023-09-21 10:43 ` Bruce Richardson
2023-09-21 10:47 ` Bruce Richardson
2023-09-22 9:31 ` [PATCH v2] net/af_xdp: fix cflags to appropriate UMEM feature Shibin Koikkara Reeny
2023-09-28 9:25 ` [PATCH v3] net/af_xdp: fix missing " Shibin Koikkara Reeny
2023-09-28 9:32 ` Bruce Richardson
2023-09-29 11:45 ` Ferruh Yigit
2023-10-02 12:48 ` [PATCH v4] " Shibin Koikkara Reeny
2023-10-02 13:01 ` Bruce Richardson
2023-10-02 13:15 ` Ferruh Yigit [this message]
2023-10-02 13:23 ` Bruce Richardson
2023-10-03 9:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24c4c344-1c71-4d13-9fc7-8f4eb7601f44@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=shibin.koikkara.reeny@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).