From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files
Date: Tue, 24 Oct 2017 01:23:42 +0200 [thread overview]
Message-ID: <25159799.6mpjox5pv3@xps> (raw)
In-Reply-To: <20171019164559.GA20056@bricha3-MOBL3.ger.corp.intel.com>
19/10/2017 18:45, Bruce Richardson:
> On Thu, Oct 19, 2017 at 05:36:24PM +0100, Bruce Richardson wrote:
> > Both Linux and BSD EALs should provide exactly the same set of functions
> > to the user, even if in some cases the function is a stub returning
> > ENOTSUP. Because of this we should only need a single version.map file for
> > all of EAL - not one each for Linux and FreeBSD.
> >
> > Unfortunately, there was some inconsistencies in the two EALs, specifically
> > 4 functions were missing from the BSD interrupts files. As part of adding
> > the needed stubs, I also discovered that there was nothing terribly
> > Linux-specific about the Linux-specific rte_interrupts.h file, which
> > appeared to contain a superset of the BSD contents. Therefore, this file
> > could be made common also.
> >
> > The net result is that there are now zero BSD-specific EAL headers, and
> > only a single Linux one for KNI. The version.map file is now moved to a
> > common location also, just inside rte_eal directory.
> >
> > [While an argument could be made to put it in common, this location works
> > best for integration with the existing meson build-sysetm work. It also
> > allows the same version file to be used for non-posix-like environments
> > which may not use the "common" folder as much]
> >
> >
> > Bruce Richardson (5):
> > eal/bsdapp: align interrupt include file with Linux version
> > eal/bsdapp: fix missing interrupt stub functions
> > eal: merge bsdapp and linuxapp interrupt headers
> > eal: mark internal interrupts file as such to doxygen
> > eal: use a single version map file
> >
>
> Compilation tested for both static and shared builds on FreeBSD 11.0 and
> Fedora 26.
Applied, thanks
prev parent reply other threads:[~2017-10-23 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 16:36 Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 1/5] eal/bsdapp: align interrupt include file with Linux version Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 2/5] eal/bsdapp: fix missing interrupt stub functions Bruce Richardson
2017-10-20 9:12 ` Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 3/5] eal: merge bsdapp and linuxapp interrupt headers Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 4/5] eal: mark internal interrupts file as such to doxygen Bruce Richardson
2017-10-19 16:36 ` [dpdk-dev] [PATCH 5/5] eal: use a single version map file Bruce Richardson
2017-10-23 23:21 ` Thomas Monjalon
2017-10-24 9:48 ` Bruce Richardson
2017-10-19 16:45 ` [dpdk-dev] [PATCH 0/5] Merge Linux and BSD EAL map files Bruce Richardson
2017-10-23 23:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25159799.6mpjox5pv3@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).