From: Thomas Monjalon <thomas@monjalon.net>
To: Phil Yang <phil.yang@arm.com>
Cc: dev@dpdk.org, nd@arm.com, anatoly.burakov@intel.com,
herbert.guan@arm.com
Subject: Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test
Date: Wed, 25 Apr 2018 19:07:28 +0200 [thread overview]
Message-ID: <2533962.DYNjplGVFj@xps> (raw)
In-Reply-To: <1517883698-12921-1-git-send-email-phil.yang@arm.com>
Hi,
Your patch has been forgotten for months.
Do not hesitate to ping if no reply.
I have a question below.
06/02/2018 03:21, Phil Yang:
> --- a/test/test/test_eal_flags.c
> +++ b/test/test/test_eal_flags.c
> -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10)
> +#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 20)
Why the above change?
> @@ -1138,10 +1138,11 @@ test_memory_flags(void)
> - int i, num_sockets = get_number_of_sockets();
> + int i, num_sockets = RTE_MIN(get_number_of_sockets(),
> + RTE_MAX_NUMA_NODES);
> #endif
>
> - if (num_sockets <= 0 || num_sockets > RTE_MAX_NUMA_NODES) {
> + if (num_sockets <= 0) {
> printf("Error - cannot get number of sockets!\n");
> return -1;
> }
>
next prev parent reply other threads:[~2018-04-25 17:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 2:21 Phil Yang
2018-04-25 17:07 ` Thomas Monjalon [this message]
2018-04-26 2:19 ` Phil Yang
2018-04-26 16:06 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2533962.DYNjplGVFj@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=herbert.guan@arm.com \
--cc=nd@arm.com \
--cc=phil.yang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).