From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Shreyansh Jain <shreyansh.jain@nxp.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
Date: Tue, 11 Oct 2016 15:57:29 +0200 [thread overview]
Message-ID: <2554688.6PDizipyct@xps13> (raw)
In-Reply-To: <20161011133824.GA31866@hmsreliant.think-freely.org>
2016-10-11 09:38, Neil Horman:
> This also begs the question in my mind, is it really worth changing the macro?
> I really don't think it is. The registration macros are pretty descriptive as
> they stand, and have already changed 3 or 4 times in the last 6 months, which
> suggests to me that any change here is really just churn more than meaningful
> change. You can make the argument that the name might be more in line with the
> library its implemented in or what not, but in truth, its easy to understand
> what the macros do (in their previous or current incantations), and any change
> that just makes them the same as other macros in their naming is really more
> trouble than its worth.
Neil, the long term goal is to stop having some identifiers which do not
start with RTE_ in our exported .h files.
I think it is a reasonable policy, for a library, to live in a well defined
namespace.
next prev parent reply other threads:[~2016-10-11 13:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 13:33 Shreyansh Jain
2016-10-07 13:33 ` [dpdk-dev] [PATCH 2/3] eal/drivers: prefix VDEV driver REGISTER macro " Shreyansh Jain
2016-10-07 13:33 ` [dpdk-dev] [PATCH 3/3] eal/drivers: prefix driver param " Shreyansh Jain
2016-10-07 13:41 ` [dpdk-dev] [PATCH 1/3] eal/drivers: prefix driver REGISTER macros " Shreyansh Jain
2016-10-07 13:51 ` Thomas Monjalon
2016-10-07 14:18 ` Neil Horman
2016-10-08 13:01 ` Shreyansh Jain
2016-10-08 13:00 ` Shreyansh Jain
2016-10-10 12:56 ` Neil Horman
2016-10-11 6:36 ` Shreyansh Jain
2016-10-11 7:27 ` Thomas Monjalon
2016-10-11 13:38 ` Neil Horman
2016-10-11 13:57 ` Thomas Monjalon [this message]
2016-10-11 14:57 ` Neil Horman
2016-10-12 4:29 ` Shreyansh Jain
2016-10-07 13:45 ` Thomas Monjalon
2016-10-08 12:47 ` Shreyansh Jain
2016-10-17 13:09 ` Neil Horman
2016-10-08 18:01 ` [dpdk-dev] [PATCH v1] drivers: prefix driver REGISTER macro with RTE EAL Shreyansh Jain
2016-10-08 18:02 ` Shreyansh Jain
2016-10-08 18:05 ` [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD Shreyansh Jain
2016-10-08 20:21 ` Thomas Monjalon
2016-10-09 15:12 ` Shreyansh Jain
2016-10-09 19:50 ` Thomas Monjalon
2016-10-10 5:11 ` Shreyansh Jain
2016-10-10 5:16 ` Shreyansh Jain
2016-10-10 5:43 ` [dpdk-dev] [PATCH v3] " Shreyansh Jain
2016-10-13 23:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2554688.6PDizipyct@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).