From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] eal: make memory segment preallocation OS-specific
Date: Fri, 13 Jul 2018 01:00:35 +0200 [thread overview]
Message-ID: <2565996.1ACNHyXsKP@xps> (raw)
In-Reply-To: <fbcb51969203cff3b8dfdf3fe2d2d6dd2c936125.1530186042.git.anatoly.burakov@intel.com>
28/06/2018 13:41, Anatoly Burakov:
> In the perfect world, it wouldn't matter how much memory was
> preallocated because most of it was always going to be private
> anonymous zero-page mappings for the duration of the program.
> However, in practice, due to peculiarities of FreeBSD, we need
> to additionally limit memory allocation there. This patch moves
> the segment preallocation to EAL private functions that will be
> implemented by an OS-specific EAL rather than being in the common
> memory-related code.
>
> Since there is no support for growing/shrinking memory use at
> runtime on FreeBSD anyway, this does not inhibit any functionality
> but makes core dumps faster even on default settings.
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>
> Notes:
> For Linuxapp, this is 99% code move (aside from slight changes due to
> code deduplication between Linuxapp EAL and old common memory code),
> while for FreeBSD it's mostly code move but with changes due to
> dropping 32-bit code and implementing FreeBSD-specific limits on
> memory preallocation outlined in the commit.
Applied, thanks
prev parent reply other threads:[~2018-07-12 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 16:13 [dpdk-dev] [PATCH 1/3] eal/bsdapp: fix segment index display Anatoly Burakov
2018-06-11 16:13 ` [dpdk-dev] [PATCH 2/3] eal/bsdapp: concatenate adjacent segments Anatoly Burakov
2018-06-11 16:13 ` [dpdk-dev] [PATCH 3/3] eal: make memory segment preallocation OS-specific Anatoly Burakov
2018-06-28 11:41 ` [dpdk-dev] [PATCH v2 1/3] eal/bsdapp: fix segment index display Anatoly Burakov
2018-06-28 11:41 ` [dpdk-dev] [PATCH v2 2/3] eal/bsdapp: concatenate adjacent segments Anatoly Burakov
2018-06-28 11:41 ` [dpdk-dev] [PATCH v2 3/3] eal: make memory segment preallocation OS-specific Anatoly Burakov
2018-07-12 23:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2565996.1ACNHyXsKP@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).