From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "Tao, Zhe" <zhe.tao@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: configure the vector PMD option as no for default for l3fwd undefined ptype issue
Date: Mon, 23 Nov 2015 12:11:45 +0100 [thread overview]
Message-ID: <2568185.VIrrg0cgCb@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A94AFAA@SHSMSX104.ccr.corp.intel.com>
> > Configure the vector PMD option as no for default as a work around for l3fwd.
> > After the l3fwd app can handle the undefined ptype or the i40e vPMD can
> > return the ptype, the option will be set as yes for default again.
> >
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
Few comments:
1/ The issue is not described.
2/ The release notes should be updated in the section "known issues".
3/ Changing the default config option won't prevent users from enable it.
If it is broken, it is better to fix or revert it.
next prev parent reply other threads:[~2015-11-23 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 16:46 Zhe Tao
2015-11-18 5:30 ` Zhang, Helin
2015-11-23 11:11 ` Thomas Monjalon [this message]
2015-11-23 18:47 ` [dpdk-dev] [PATCH v2] " Zhe Tao
2015-11-23 22:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2568185.VIrrg0cgCb@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=zhe.tao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).