From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Robert Sanford <rsanford@akamai.com>,
erik.g.carrillo@intel.com, olivier.matz@6wind.com,
shreyansh.jain@nxp.com
Subject: Re: [dpdk-dev] [PATCH] lcore: make semantics of lcore role function more intuitive
Date: Thu, 26 Apr 2018 16:30:42 +0200 [thread overview]
Message-ID: <2584582.pWCQVUZt55@xps> (raw)
In-Reply-To: <b25e9076c53da76cc658363bab8de60ebd69d10b.1524745985.git.anatoly.burakov@intel.com>
26/04/2018 15:42, Anatoly Burakov:
> rte_lcore_has_role() returns 0 if role of lcore matches requested
> role. The return value of the API is confusing, and this is a known
> problem with a deprecation notice announcing the change to more
> intuitive semantics:
>
> Commit 064518f68d48 ("doc: announce EAL API change to lcore role function")
> Cc: erik.g.carrillo@intel.com
>
> Implement changes announced in the deprecation notice, and remove it.
> Also, fix usages of this API to reflect the change. Control thread patches
> expected new behavior and were broken before, now they are fixed as well.
>
> Fixes: d651ee4919cd ("eal: set affinity for control threads")
> Cc: olivier.matz@6wind.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-04-26 14:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 13:42 Anatoly Burakov
2018-04-26 14:30 ` Thomas Monjalon [this message]
2018-04-26 14:44 ` Carrillo, Erik G
2018-04-26 14:54 ` Thomas Monjalon
2018-04-26 14:56 ` Carrillo, Erik G
2018-04-26 15:37 ` Stephen Hemminger
2018-04-26 15:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2584582.pWCQVUZt55@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=rsanford@akamai.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).